Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Mandy Chung
> On Feb 19, 2016, at 2:47 AM, Wang Weijun wrote: > > Updated at the same URL > > http://cr.openjdk.java.net/~weijun/8130302/webrev.01 > > The help looks like this now: > > -provider add security provider by name (e.g. SunPKCS11) > [-providerArg ] configure argument for -pro

Re: jmx-dev [ping] Re: RFR 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials (Round 2)

2016-02-19 Thread Jaroslav Bachorik
On 18.2.2016 10:40, Daniel Fuchs wrote: Hi Jaroslav, Looks good. BTW - shouldn't you take sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java out of the problem list as well? I see that 8147985 is fixed. Sure, but that will have to be a different changeset and a different review.

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Alan Bateman
On 19/02/2016 11:17, Wang Weijun wrote: : When and which repo should this change go into? Certainly this is all about jake but there are a lot of other changes, esp, the option list. Good question. Ideally jdk9/dev as we are trying to minimize the changes in the jake forest. If you do that

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Wang Weijun
> On Feb 19, 2016, at 6:58 PM, Alan Bateman wrote: > > One other thing is whether we should add a section to JEP 261 on these tool > updates. I had originally assumed that the updates to these tools would > follow the module system into JDK 9 but you've turned up early :-) When and which repo

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Alan Bateman
On 19/02/2016 10:47, Wang Weijun wrote: Updated at the same URL http://cr.openjdk.java.net/~weijun/8130302/webrev.01 The help looks like this now: -provider add security provider by name (e.g. SunPKCS11) [-providerArg ] configure argument for -provider -providerclas

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Wang Weijun
Updated at the same URL http://cr.openjdk.java.net/~weijun/8130302/webrev.01 The help looks like this now: -provider add security provider by name (e.g. SunPKCS11) [-providerArg ] configure argument for -provider -providerclass add security provider by fully-qualified c

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Wang Weijun
> On Feb 19, 2016, at 5:36 PM, Alan Bateman wrote: > > > On 19/02/2016 09:07, Wang Weijun wrote: >> : >> I don't want the line to be too long. Is the preferred terminal width still >> 80 now? I noticed the java help output still fits with 80 chars but javac is >> already not. > It could fit o

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Alan Bateman
On 19/02/2016 09:07, Wang Weijun wrote: : I don't want the line to be too long. Is the preferred terminal width still 80 now? I noticed the java help output still fits with 80 chars but javac is already not. It could fit on a second line, the java launcher usage output does this. I see jarsig

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Wang Weijun
> On Feb 19, 2016, at 4:42 PM, Alan Bateman wrote: > > On 19/02/2016 08:22, Wang Weijun wrote: >> A new webrev at >> >>http://cr.openjdk.java.net/~weijun/8130302/webrev.01/ >> >> The options for keytool have >> >> -provider [-providerArg ]add a provider by name >> -providerclas

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Alan Bateman
On 19/02/2016 08:22, Wang Weijun wrote: A new webrev at http://cr.openjdk.java.net/~weijun/8130302/webrev.01/ The options for keytool have -provider [-providerArg ]add a provider by name -providerclass [-providerArg ] add a provider by classname (omit some words because lin

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-19 Thread Wang Weijun
A new webrev at http://cr.openjdk.java.net/~weijun/8130302/webrev.01/ The options for keytool have -provider [-providerArg ]add a provider by name -providerclass [-providerArg ] add a provider by classname (omit some words because line is too long) for jarsigner [-provider