Re: [9] RFR: 8159501: ShortRSAKey512.java intermittently times out

Looks fine to me. Thanks, Xuelei On 6/18/2016 7:21 AM, Artem Smotrakov wrote: > Hello, > > Please review the patch below for > javax/net/ssl/TLSv12/ShortRSAKey512.java test. > > The test has been seen to fail intermittently with a time out. I was not > able to reproduce this failure. The test f

[9] RFR: 8159501: ShortRSAKey512.java intermittently times out

Hello, Please review the patch below for javax/net/ssl/TLSv12/ShortRSAKey512.java test. The test has been seen to fail intermittently with a time out. I was not able to reproduce this failure. The test fails with "Client died ..." message which occurs in case of exception on client side. But

Re: RFR 8157730: Mark deprecated java.security.{Identity, IdentityScope, Signer} APIs with forRemoval=true

Sure. (It works for packages too.) > On 17 Jun 2016, at 18:54, [email protected] wrote: > > Hello, > > While you are at that code, can the JavaDoc @code classnames be changed into > @link as well? (Not sure if it works for packages). > > Gruss > Bernd > > -- > http://bernd.eckenfels.ne

Re: RFR 8157730: Mark deprecated java.security.{Identity, IdentityScope, Signer} APIs with forRemoval=true

Hello, While you are at that code, can the JavaDoc @code classnames be changed into @link as well? (Not sure if it works for packages). Gruss Bernd -- http://bernd.eckenfels.net -Original Message- From: Sean Mullan To: Vincent Ryan , OpenJDK Sent: Fr., 17 Juni 2016 16:41 Subject:

Re: RFR 8157730: Mark deprecated java.security.{Identity, IdentityScope, Signer} APIs with forRemoval=true

Looks fine to me. --Sean On 06/17/2016 08:52 AM, Vincent Ryan wrote: Three Identity-related classes were deprecated in JDK 1.2. Please review the patch below that marks them as candidates for removal in a future JDK release. See http://openjdk.java.net/jeps/277 for details of the enhanced depr

Re: RFR 8159805: sun/security/tools/jarsigner/warnings/NoTimestampTest.java fails after JDK-8027781

Looks fine. --Sean On 06/17/2016 08:40 AM, Wang Weijun wrote: I forgot to update the test as well. Please review this patch: diff --git a/test/sun/security/tools/jarsigner/warnings/Test.java b/test/sun/security/tools/jarsigner/warnings/Test.java --- a/test/sun/security/tools/jarsigner/warning

RFR 8157730: Mark deprecated java.security.{Identity, IdentityScope, Signer} APIs with forRemoval=true

Three Identity-related classes were deprecated in JDK 1.2. Please review the patch below that marks them as candidates for removal in a future JDK release. See http://openjdk.java.net/jeps/277 for details of the enhanced deprecation annotation. Thanks. diff

Re: RFR 8158589: Possible integer overflow issues for DRBG

> On Jun 17, 2016, at 7:45 PM, Sean Mullan wrote: > > On 06/16/2016 10:50 PM, Wang Weijun wrote: >> >>> On Jun 17, 2016, at 10:31 AM, Xuelei Fan wrote: >>> >>> What did you mean "can a long field be a safe volatile?" >> >> A long value cannot be updated atomically, and I am afraid that anoth

RFR 8159805: sun/security/tools/jarsigner/warnings/NoTimestampTest.java fails after JDK-8027781

I forgot to update the test as well. Please review this patch: diff --git a/test/sun/security/tools/jarsigner/warnings/Test.java b/test/sun/security/tools/jarsigner/warnings/Test.java --- a/test/sun/security/tools/jarsigner/warnings/Test.java +++ b/test/sun/security/tools/jarsigner/warnings/Test.

Re: RFR 8158589: Possible integer overflow issues for DRBG

On 06/16/2016 10:50 PM, Wang Weijun wrote: On Jun 17, 2016, at 10:31 AM, Xuelei Fan wrote: What did you mean "can a long field be a safe volatile?" A long value cannot be updated atomically, and I am afraid that another thread might only see half bits updated and the other half not. Have

Re: RFR 8158633: BASE64 encoded cert not correctly parsed

Looks fine to me, but can you add a comment to the bug report explaining what the issue was? Thanks, Sean On 06/17/2016 06:57 AM, Wang Weijun wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8158633/webrev.00/ *Jon*: If I write this line inside a .java test: @test

RFR 8158633: BASE64 encoded cert not correctly parsed

Please review the fix at http://cr.openjdk.java.net/~weijun/8158633/webrev.00/ *Jon*: If I write this line inside a .java test: @test @run main/othervm -Dfile.encoding=UTF-16 PemEncoding this error occurs: STDERR: ��Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException:

Re: RFR 8156471: test/sun/security/krb5/auto/TestHosts should not be modified in-place

Hi Max, yes that entry is an error an empty TestHosts should have been pushed the idea is that each test will setup its mappings, with the first addition truncating the TestHosts file, thus creating and empty file. regards Mark On 06/06/2016 11:34, Wang Weijun wrote: Please review the