Re: RFR 8164656: krb5 does not retry if TCP connection timeouts

2016-08-23 Thread Xuelei Fan
OK. On 8/24/2016 10:00 AM, Weijun Wang wrote: I've updated the test at http://cr.openjdk.java.net/~weijun/8164656/webrev.01/ No more ratio things. When the ratio was invented for BadKdc, it was because it uses real KDCs and we have to find a balance between unexpected timeout and test speed

Re: RFR 8164656: krb5 does not retry if TCP connection timeouts

2016-08-23 Thread Weijun Wang
I've updated the test at http://cr.openjdk.java.net/~weijun/8164656/webrev.01/ No more ratio things. When the ratio was invented for BadKdc, it was because it uses real KDCs and we have to find a balance between unexpected timeout and test speed. Changing a single ratio is much easier to mo

Re: RFR 8164656: krb5 does not retry if TCP connection timeouts

2016-08-23 Thread Xuelei Fan
Looks fine to me. Xuelei On 8/24/2016 12:14 AM, Weijun Wang wrote: Please review the change at http://cr.openjdk.java.net/~weijun/8164656/webrev.00/ The old try-catch is only on send/receive, but NetClient.getInstance() could also timeout for TCP when it calls Socket::connect(dest,timeout)

[jdk9] (XS) RFR: 6474807: (smartcardio) CardTerminal.connect() throws CardException instead of CardNotPresentException

2016-08-23 Thread Ivan Gerasimov
Hello! When underlying PCSC driver returns the error SCARD_E_NO_SMARTCARD, we should throw a more specialized exception of type CardNotPresentException. Currently, the plain CardException is thrown, which makes some TCK tests unhappy. BUGURL: https://bugs.openjdk.java.net/browse/JDK-6474807

RFR 8164656: krb5 does not retry if TCP connection timeouts

2016-08-23 Thread Weijun Wang
Please review the change at http://cr.openjdk.java.net/~weijun/8164656/webrev.00/ The old try-catch is only on send/receive, but NetClient.getInstance() could also timeout for TCP when it calls Socket::connect(dest,timeout). Therefore move the catch to a higher level. The test is brand ne

Re: [9] RFR: 8006690: sun/security/krb5/auto/BadKdc* tests fails intermittently

2016-08-23 Thread Weijun Wang
The change looks fine. Hopefully this can let intermittent failures go away. Thanks Max On 8/23/2016 16:19, Sibabrata Sahoo wrote: Hi, Please review the patch for intermittent failures in “sun/security/krb5/auto/BadKdc*” JBS: https://bugs.openjdk.java.net/browse/JDK-8006690 Webrev: http:

[9] RFR: 8006690: sun/security/krb5/auto/BadKdc* tests fails intermittently

2016-08-23 Thread Sibabrata Sahoo
Hi, Please review the patch for intermittent failures in "sun/security/krb5/auto/BadKdc*" JBS: https://bugs.openjdk.java.net/browse/JDK-8006690 Webrev: http://cr.openjdk.java.net/~ssahoo/8006690/webrev.00/ Description: Some times when the test machine is slow the number of retry for