On 8/29/2016 20:18, Alan Bateman wrote:
FilePermCompat is a ugly, particularly FilePermission changing its
public fields.
Do you prefer the traditional SharedSecrets way?
SharedSecrets.setJavaIoFilePermissionAccess(
new JavaIoFilePermissionAccessImpl());
Also method names like
readAllBytes() wants to real *all* data. If this is during a long time
communication, and the peer sends a BER using indefinite length, and
then wait for the next round of dialog without closing the stream, will
readAllBytes() hang?
Is it possible to create a new method readAllAvailables() her
Changes look fine.
Thanks,
Valerie
On 8/23/2016 10:20 AM, Ivan Gerasimov wrote:
Hello!
When underlying PCSC driver returns the error SCARD_E_NO_SMARTCARD, we
should throw a more specialized exception of type
CardNotPresentException.
Currently, the plain CardException is thrown, which makes
Hi Svetlana,
It looks fine, but I am not an official reviewer.
"keystorePath" in readTest() can be a static field.
I also meant that one test with SequenceInputStream seems to be enough,
so you could just add a new test case to ReadP12Test.java. But it's fine.
I am not sure how DerIndefLenCo
Hi Artem,
thank you for your replay. I've updated copyright and made separate test
for this bug.
As for Arrays.copyOfRange() unfortunately it won't simplify code in my
case. I need to extend an array, not to get a sub-array of existing one.
http://cr.openjdk.java.net/~snikandrova/8157404/webr
Hi,
Please review the patch for "sun/security/provider/SecureRandom/AutoReseed.java
failed with timeout"
JBS: https://bugs.openjdk.java.net/browse/JDK-8164922
Webrev: http://cr.openjdk.java.net/~ssahoo/8164922/webrev.00/
Description:
The Test was blocked while generating seed. I have
Change looks fine.
Thanks
Max
On 8/29/2016 21:36, Sibabrata Sahoo wrote:
Hi Max,
Here is updated webrev: http://cr.openjdk.java.net/~ssahoo/8015595/webrev.02/
Addressed all the following comments.
Thanks,
Siba
Hi Max,
Here is updated webrev: http://cr.openjdk.java.net/~ssahoo/8015595/webrev.02/
Addressed all the following comments.
Thanks,
Siba
-Original Message-
From: Weijun Wang
Sent: Monday, August 29, 2016 6:14 PM
To: Sibabrata Sahoo; security-dev@openjdk.java.net
Subject: Re: [9] RFR: 8
Hi Alan
I am glad you think this change is useful.
As for the 3-value property, in my opinion even the absolute <=>
relative translation might not be really useful in a production
environment. Who can guarantee a program is always launched from a
certain directory and access a file using a re
Looks fine mostly. Some nits:
58 // - SocketTimeoutException may occur in MAC because it
will not throw
s/in MAC/on Mac/.
66 + "occured or PortUnreachableException not
thrown by the "
s/or/which means/.
76 File f = new File("unreachable.kr
Hi Max,
Please find the updated webrev addressing all comments bellow:
http://cr.openjdk.java.net/~ssahoo/8015595/webrev.01/
Thanks,
Siba
-Original Message-
From: Weijun Wang
Sent: Monday, August 29, 2016 6:36 AM
To: Sibabrata Sahoo; security-dev@openjdk.java.net
Subject: Re: [9] RFR:
On 25/08/2016 04:55, Weijun Wang wrote:
Hi All
Please take a look at
http://cr.openjdk.java.net/~weijun/8164705/webrev.00
From the beginning of JDK, FilePermission canonicalizes the input path
and use the result in implies() and equals(). This has been a big
performance hurt and leads to
12 matches
Mail list logo
