Re: RFR: 8168078: Remove permission to read all system properties granted to the jdk.crypto.ec module

2016-10-17 Thread Xuelei Fan
OK. Xuelei On 10/18/2016 5:18 AM, Sean Mullan wrote: I had to make a small update to the webrev to PKCS11Test.java because the TestEC test failed on Windows. Some deployment-specific security providers will throw a ServiceConfigurationError if not granted the right permissions. These permission

Re: [9] RFR: 8166530: sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java fails intermittently

2016-10-17 Thread Artem Smotrakov
Hello, Please take a look. Artem On 10/07/2016 01:33 PM, Artem Smotrakov wrote: Hello, Please review the patch below for sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java test. The test has been observed to fail intermittently, but the failure is not reproducible standalone. The

Re: RFR: 8168078: Remove permission to read all system properties granted to the jdk.crypto.ec module

2016-10-17 Thread Sean Mullan
I had to make a small update to the webrev to PKCS11Test.java because the TestEC test failed on Windows. Some deployment-specific security providers will throw a ServiceConfigurationError if not granted the right permissions. These permissions may not be configured correctly and are outside the

Re: RFR: 8168078: Remove permission to read all system properties granted to the jdk.crypto.ec module

2016-10-17 Thread Xuelei Fan
Looks fine to me. Xuelei On 10/17/2016 10:51 PM, Sean Mullan wrote: Please review this fix to remove granting the unnecessary PropertyPermission to the jdk.crypto.ec module: http://cr.openjdk.java.net/~mullan/webrevs/8168078/webrev.00/ The existing TestEC test has been modified to also run un

Re: RFR: 8165712: Grant permission to read specific properties instead of all to the jdk.crypto.ucrypto module

2016-10-17 Thread Xuelei Fan
Looks fine to me. Xuelei On 10/14/2016 3:44 AM, Sean Mullan wrote: Please review this fix to only grant the necessary PropertyPermissions to the jdk.crypto.ucrypto module. In UcryptoProvider I also moved the System.getProperty("os.name") inside doPrivileged (just in case permission to read thi

Re: RFR: 8168078: Remove permission to read all system properties granted to the jdk.crypto.ec module

2016-10-17 Thread Vincent Ryan
Your fix looks fine to me Sean. Thanks. > On 17 Oct 2016, at 15:51, Sean Mullan wrote: > > Please review this fix to remove granting the unnecessary PropertyPermission > to the jdk.crypto.ec module: > > http://cr.openjdk.java.net/~mullan/webrevs/8168078/webrev.00/ > > The existing TestEC tes

RFR: 8168078: Remove permission to read all system properties granted to the jdk.crypto.ec module

2016-10-17 Thread Sean Mullan
Please review this fix to remove granting the unnecessary PropertyPermission to the jdk.crypto.ec module: http://cr.openjdk.java.net/~mullan/webrevs/8168078/webrev.00/ The existing TestEC test has been modified to also run under a SecurityManager to verify that removing the permission does not