RFR[9] JDK-8170523: Some PKCS11 test cases are ignored with security manager

2016-12-01 Thread John Jiang
Hi, Some PKCS11 tests call PKCS11Test.getDistro(), which run command "uname -v", to determine the OS distro. But if the tests enable security manager and don't grant appropriate file permission, PKCS11Test.getDistro() fails to get the distro. Then, the associated cases will be ignored since the

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Phil Race
Sorry. it is ops->GetRasInfo(env, ops, lockInfo); that initialises it .. That is still before the dereference Anyway, what was the reason for updating one function, but not the other. I don't mind the change, but the inconsistency looks odd. -phil. On 12/01/2016 03:03 AM, Lindenmaier, Goet

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Semyon Sadetsky
yes, this is a potential issue. But actually cases MID,FOCUS,BLACK,WHITE are never used. But the fix is wrong. It should be color.alpha = 1; --Semyon On 01.12.2016 08:05, Prasanta Sadhukhan wrote: Also, in gtk3_interface.c, there is this change for color.alpha 2219 color.alpha = 0; in gtk3

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Prasanta Sadhukhan
Also, in gtk3_interface.c, there is this change for color.alpha 2219 color.alpha = 0; in gtk3_get_color_for_flags() but it is used in gtk3_get_color_for_state() where it is not initialized 2268 GdkRGBA color; Regards Prasanta On 12/1/2016 1:28 AM, Phil Race wrote: Hi Goetz, DataBuffer

Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-12-01 Thread Sean Mullan
I enhanced the test case to test more scenarios where MD5 is either disabled via the jdk.tls.disabledAlgorithms or the jdk.certpath.disabledAlgorithms property. Please take another look and let me know if you are ok with it: http://cr.openjdk.java.net/~mullan/webrevs/8170131/webrev.01/ Thanks

Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection

2016-12-01 Thread Claes Redestad
On 2016-12-01 18:10, Alan Bateman wrote: On 01/12/2016 15:33, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency.

Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection

2016-12-01 Thread Alan Bateman
On 01/12/2016 15:33, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this parti

RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection

2016-12-01 Thread Claes Redestad
Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this particular change. Bug: https://bugs.openjdk.java

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
Ah, no, that is just the field that is initialized with the Result of gtk3_get_color_for_flags() why I need to initialize it there. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 1. Dezember 2016 12:10 > To: 'Prasanta Sadhukhan' ; Phil Race >

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
Hi Prasanta, good point, I added that too. Best regards, Goetz. > -Original Message- > From: Prasanta Sadhukhan [mailto:[email protected]] > Sent: Donnerstag, 1. Dezember 2016 06:05 > To: Phil Race ; Sergey Bylokhov > ; Lindenmaier, Goetz > ; Vincent Ryan > Cc: awt-...@op

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
Hi Phil, > Did you actually compile this ? The variable is called "rasBase", not > "resBase". Yes, I compiled it, and I fixed the error, but that was another repo I use for the coverity checks. Somehow it did not find its way into the webrev. I don't see where ops->Lock() initializes this fie

RE: RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
Hi Christoph, I changed the code in fontpath.c to use snprintf, that seems much better as the concatenated string is a literal anyways. Also, I fixed the spaces. I'll post a new webrev once I'm through all the reviews. Best regards, Goetz. > -Original Message- > From: Langer, Chris