Re: RFR 8200468: Port the native GSS-API bridge to Windows

2018-04-12 Thread Weijun Wang
> On Apr 13, 2018, at 9:09 AM, Valerie Peng wrote: > > Hi Max, > > Changes look fine, just some very minor nit: Maybe it's better to remove the > unused variables which currently are only commented out (GSSLibStub.c and > NativeUtil.c). Sure. > When testing, did u enable debugging? If not,

Re: RFR 8200468: Port the native GSS-API bridge to Windows

2018-04-12 Thread Valerie Peng
Hi Max, Changes look fine, just some very minor nit: Maybe it's better to remove the unused variables which currently are only commented out (GSSLibStub.c and NativeUtil.c). When testing, did u enable debugging? If not, maybe worthwhile to try it out to make sure things work as expected. Tha

RFR: 8198240: Allow cacerts test to pass when GTECyberTrust root expires

2018-04-12 Thread Rajan Halade
Please review this test fix to allow exception list to 90 days expiry policy. Fix also modifies the error reporting to report alias of certificate being checked. Webrev: http://cr.openjdk.java.net/~rhalade/8198240/webrev.00/ Thanks, Rajan

Re: RFR: 8152821: Merge jdk.internal.misc.JavaSecurityAccess and jdk.internal.misc.JavaSecurityProtectionDomainAccess shared secrets

2018-04-12 Thread Claes Redestad
On 2018-04-12 20:45, Sean Mullan wrote: Please update copyright dates. Otherwise looks fine. Sure, and thanks for reviewing! /Claes

Re: RFR: 8152821: Merge jdk.internal.misc.JavaSecurityAccess and jdk.internal.misc.JavaSecurityProtectionDomainAccess shared secrets

2018-04-12 Thread Sean Mullan
Please update copyright dates. Otherwise looks fine. --Sean On 4/12/18 1:24 PM, Claes Redestad wrote: Hi, ProtectionDomain creates both the JavaSecurityAccess and the JavaSecurityProtectionDomainAccess SharedSecrets, and since 9 both are always created eagerly during early bootstrap. It seem

RFR: 8152821: Merge jdk.internal.misc.JavaSecurityAccess and jdk.internal.misc.JavaSecurityProtectionDomainAccess shared secrets

2018-04-12 Thread Claes Redestad
Hi, ProtectionDomain creates both the JavaSecurityAccess and the JavaSecurityProtectionDomainAccess SharedSecrets, and since 9 both are always created eagerly during early bootstrap. It seems safe to merge these two, as suggested, which is a tiny startup improvement and cleanup. Webrev: http