Re: [14] RFR 8228745: sun/security/tools/jarsigner/Warning.java test timeout

2019-07-29 Thread Xuelei Fan
Looks good to me. Xuelei On 7/29/2019 7:03 PM, Weijun Wang wrote: Turns out a previous code change accidentally ignore the input of a process, and this test calls this method. Please review the patch below: *diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt* *--- a/test/jdk/Pr

[14] RFR 8228745: sun/security/tools/jarsigner/Warning.java test timeout

2019-07-29 Thread Weijun Wang
Turns out a previous code change accidentally ignore the input of a process, and this test calls this method. Please review the patch below: diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -661,8 +661,6 @@ sun/sec

Re: RFR: 8228755: ProblemList sun/security/tools/jarsigner/Warning.java

2019-07-29 Thread Xuelei Fan
Looks good to me. Xuelei On 7/29/2019 3:06 PM, Rajan Halade wrote: Please review this patch to problem list Warning.java. I am not able to reproduce the failure and will require more time to find root cause and fix. diff -r f459f98aa30d test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txtM

RFR: 8228755: ProblemList sun/security/tools/jarsigner/Warning.java

2019-07-29 Thread Rajan Halade
Please review this patch to problem list Warning.java. I am not able to reproduce the failure and will require more time to find root cause and fix. diff -r f459f98aa30d test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Mon Jul 29 20:18:43 2019 + +++ b/test/jdk/ProblemList.txt Mon Jul

Re: [14] RFR 8228668: compiler/codegen/aes/TestAESMain.java failed with GCM mode must be used with NoPadding

2019-07-29 Thread Valerie Peng
Sure, thanks for review~ Valerie On 7/26/2019 4:17 PM, Xuelei Fan wrote: Looks good to me. Just a nit:   58  "NoPadding":"PKCS5Padding"); I may use a white space before and after the "?" and ":" operators. Xuelei On 7/26/2019 3:07 PM, Valerie Peng wrote: Sorry, should be for JDK 14

Re: Request for Review [14] JDK-8228742 Get back javax/net/ssl/SSLSocket/Tls13PacketSize.java

2019-07-29 Thread Xuelei Fan
Updated. Thanks, Xuelei On 7/29/2019 11:08 AM, Sean Mullan wrote: I would suggest changing synopsis to "Remove javax/net/ssl/SSLSocket/Tls13PacketSize.java from ProblemList". I would also add a link to JDK-8224829. Looks fine otherwise. --Sean On 7/29/19 1:48 PM, Xuelei Fan wrote: Hi, Co

Re: Request for Review [14] JDK-8228742 Get back javax/net/ssl/SSLSocket/Tls13PacketSize.java

2019-07-29 Thread Sean Mullan
I would suggest changing synopsis to "Remove javax/net/ssl/SSLSocket/Tls13PacketSize.java from ProblemList". I would also add a link to JDK-8224829. Looks fine otherwise. --Sean On 7/29/19 1:48 PM, Xuelei Fan wrote: Hi, Could I have the following udpate reviewed?    http://cr.openjdk.java.

Request for Review [14] JDK-8228742 Get back javax/net/ssl/SSLSocket/Tls13PacketSize.java

2019-07-29 Thread Xuelei Fan
Hi, Could I have the following udpate reviewed? http://cr.openjdk.java.net/~xuelei/8228742/webrev.00/ The test javax/net/ssl/SSLSocket/Tls13PacketSize.java was problem listed for JDK-8224718, which has been fixed in the duplicated JDK-8224829. The test can be back now. Thanks, Xuelei

Re: RFR [14] JDK-8226374 Restrict signature algorithms and named groups

2019-07-29 Thread Xuelei Fan
On 7/29/2019 7:57 AM, Sean Mullan wrote: On 7/28/19 1:42 PM, Xuelei Fan wrote: On 7/26/2019 7:08 AM, Xuelei Fan wrote: New webrev: http://cr.openjdk.java.net/~xuelei/8226374/webrev.03/ * src/java.base/share/classes/sun/security/ssl/ECDHServerKeyExchange.java 114 if ((name

Re: RFR [14] JDK-8226374 Restrict signature algorithms and named groups

2019-07-29 Thread Sean Mullan
On 7/28/19 1:42 PM, Xuelei Fan wrote: On 7/26/2019 7:08 AM, Xuelei Fan wrote: New webrev: http://cr.openjdk.java.net/~xuelei/8226374/webrev.03/ * src/java.base/share/classes/sun/security/ssl/ECDHServerKeyExchange.java 114 if ((namedGroup == null) || (!namedGroup.isAvailable))