Re: 8237219: Disabling the native SunEC implementation

2020-03-09 Thread Weijun Wang
SunEC.java: - isJavaSupported() has a strange name - Is it better to put the javaSupportedCurves somewhere near fields and orderFields in ECOperations.java? Thus we can update it simultaneously in the future. Or at least add a comment somewhere? ECKeyPairGenerator.java: - Is it possible to im

Re: RFR 8239928: ec/ECDSAJavaVerify.java failed due to timeout

2020-03-09 Thread Weijun Wang
A new webrev at http://cr.openjdk.java.net/~weijun/8239928/webrev.02/ Instead of checking if stderr is empty I now read the exit code. Some developer prints out debugging info in stderr. Finally, I give up fixing the test on Windows. Both dispose() and waitFor() could hang forever. Thanks,

Re: RFR: 8240686: 70 security tests are failing on Windows due to "Fetch artifact failed"

2020-03-09 Thread Sean Mullan
Hi Rajan, I see you already pushed the fix, but I was going to ask you to also make this small change to PKCS11Test.java so if this happens next time the cause of the failure won't be swallowed by the test, which made it harder to diagnose: diff -r 90c1d2c1f333 test/jdk/sun/security/pkcs11/P