Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

Hi Max, Webrev has been updated, http://cr.openjdk.java.net/~valeriep/8242151/webrev.02/. Major changes are: - Moved oidTable caching from AlgorithmId class to ObjectIdentifier class. Made ObjectIdentifier constructor private and callers have to use the of(String) method which always check

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

> On May 6, 2020, at 6:51 AM, Mikael Vidstedt > wrote: > > > Max, > > Thank you so much for the thorough review! I’m working on an incremental > webrev but could use some help - comments/questions inline.. > >> On May 4, 2020, at 6:58 AM, Weijun Wang wrote: >> >> I've gone through all

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

Hi Max, Thanks for the comments, they are very helpful. I should have webrev.02 ready in a bit. Please find comments below in line. On 5/1/2020 2:45 AM, Weijun Wang wrote: ObjectIdentifier.java - Have you thought about storing the ObjectIdentifier object somewhere?

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

John, Thanks for the review! Comments/questions inline.. > On May 4, 2020, at 4:02 PM, sha.ji...@oracle.com wrote: > > Hi, > Generally, this patch doesn't take care of the solaris/sunos/ucrypto-related > words in test summaries, code comments, configs and READMEs. > E.g. >

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

Max, Thank you so much for the thorough review! I’m working on an incremental webrev but could use some help - comments/questions inline.. > On May 4, 2020, at 6:58 AM, Weijun Wang wrote: > > I've gone through all files. Many of them are PKCS11-related, it will be nice > if Valerie can

Re: RFR[15] 8242060: Add revocation checking to jarsigner

> On May 5, 2020, at 6:16 AM, Sean Mullan wrote: > > On 5/2/20 2:19 PM, Hai-May Chao wrote: >>> Looks good otherwise. Please add a release-note and open a follow-on issue >>> to update the man page with the new option. >> Done (Release note: JDK-8244285, and man page: JDK-8244274). > > I

RFR JDK-8206925,,Support the certificate_authorities extension

Hi, Could I get the following update reviewed? RFE: https://bugs.openjdk.java.net/browse/JDK-8206925 CSR: https://bugs.openjdk.java.net/browse/JDK-821 Release-note: https://bugs.openjdk.java.net/browse/JDK-8244460 webrev: http://cr.openjdk.java.net/~xuelei/8206925/webrev.00/ The

Re: RFR[15] 8242060: Add revocation checking to jarsigner

On 5/2/20 2:19 PM, Hai-May Chao wrote: Looks good otherwise. Please add a release-note and open a follow-on issue to update the man page with the new option. Done (Release note: JDK-8244285, and man page: JDK-8244274). I added a few more details to the release note. Otherwise, looks good,

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

I am playing with keytool + BouncyCastle and generate a key pair using the sigalg "SHA3-256WITHECDSA", and `keytool -list` cannot show the signature name. So I tried 2 changes in AlgorithmId.java: 1. add both the name->oid and oid->name mapping inside collectOIDAliases() for 3rd party

Re: RFR[15] 8242060: Add revocation checking to jarsigner

> On May 4, 2020, at 10:23 PM, Weijun Wang wrote: > > > >> On May 5, 2020, at 12:36 PM, Hai-May Chao wrote: >> >> >> >>> On May 4, 2020, at 6:01 PM, Weijun Wang wrote: >>> >>> >>> On May 5, 2020, at 3:48 AM, Hai-May Chao wrote: Hi Max, > On May 2, 2020, at