Re: RFR 8247960: jarsigner says "signer errors" for some normal warnings when -strict is set

2020-07-15 Thread Hai-May Chao
Bugid added. Thanks, Hai-May > On Jul 15, 2020, at 12:06 PM, Sean Mullan wrote: > > I'll defer to Max on the code changes, but I noticed one thing on the test - > you should add the bugid to the @bug line of the test. > > --Sean > > On 7/14/20 4:09 PM, Hai-May Chao wrote: >> Hi, >> I’d

Re: RFR 8247960: jarsigner says "signer errors" for some normal warnings when -strict is set

2020-07-15 Thread Sean Mullan
I'll defer to Max on the code changes, but I noticed one thing on the test - you should add the bugid to the @bug line of the test. --Sean On 7/14/20 4:09 PM, Hai-May Chao wrote: Hi, I’d like to request a review for: JBS: https://bugs.openjdk.java.net/browse/JDK-8247960 Webrev:

Re: SSLSocketImpl and Handshake Notifier efficiency/thread pooling

2020-07-15 Thread David Schlosnagle
Hi security-dev, I'd like to revive this 7.5 year old thread for discussion as I have seen seen several high throughput applications using `SSLSocket.addHandshakeCompletedListener(HandshakeCompletedListener)` where the "HandshakeCompletedNotify-Thread" created at

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

2020-07-15 Thread Alexey Bakhtin
Hello Daniel, I’ve updated CSR as you suggested and added kerberos ldap setup commands for the client host in the JDK-8245527 Regards Alexey > On 14 Jul 2020, at 18:28, Daniel Fuchs wrote: > > Hi Alexey, > > On 10/07/2020 21:37, Alexey Bakhtin wrote: >> Updated

Re: RFR 8247960: jarsigner says "signer errors" for some normal warnings when -strict is set

2020-07-15 Thread Weijun Wang
Oops, 1101 if (hasExpiredTsaCert) { 1102 errors.add(rb.getString("The.timestamp.has.expired.")); 1103 } was inside 1058 (hasExpiredTsaCert && !signerNotExpired)) { and it should be combined with 1210 if (hasExpiredTsaCert &&

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

2020-07-15 Thread Aleks Efimov
Hi Alexey, Thanks for addressing comments and answering questions. The JNDI changes in latest webrev looks good to me. CI is also happy with the latest changes. Best, Aleksei On 10/07/2020 21:37, Alexey Bakhtin wrote: Hello Aleksei, Thank you for review. Please see my comments below.

Re: RFR 8247960: jarsigner says "signer errors" for some normal warnings when -strict is set

2020-07-15 Thread Weijun Wang
The following lines are useless now: 1053 if (badKeyUsage || badExtendedKeyUsage || badNetscapeCertType || 1054 notYetValidCert || chainNotValidated || hasExpiredCert || 1055 hasUnsignedEntry || signerSelfSigned || (legacyAlg != 0) || 1056