Looks fine to me. Thanks for the quick fix.
—Max
> 在 2020年7月25日，12:36，Martin Balao 写道：
>
> Hello Max,
>
> I'd like to propose a patch for "8250582: Revert Principal Name type to
> NT-UNKNOWN when requesting TGS Kerberos tickets" [1].
>
> Webrev.00:
>
> *
Hello Max,
I'd like to propose a patch for "8250582: Revert Principal Name type to
NT-UNKNOWN when requesting TGS Kerberos tickets" [1].
Webrev.00:
* http://cr.openjdk.java.net/~mbalao/webrevs/8250582/8250582.webrev.00/
This change is trivial and we are reverting to a previous (and known
> On Jul 24, 2020, at 6:54 AM, Weijun Wang wrote:
>
> I'd suggest changing
>
> +result = isSigning ? rb.getString("jar.signed.") :
> rb.getString("jar.verified.");
> +if ((strict) && (!errors.isEmpty())) {
> +result = isSigning ?
>
On 7/24/2020 10:32 AM, Sean Mullan wrote:
On 7/24/20 1:18 PM, Joe Darcy wrote:
-
src/jdk.security.jgss/share/classes/com/sun/security/jgss/GSSUtil.java
37 /**
38 * Do not call.
39 */
40 @Deprecated(since="16", forRemoval=true)
41 public GSSUtil() {}
Is your
On 7/24/20 1:18 PM, Joe Darcy wrote:
- src/jdk.security.jgss/share/classes/com/sun/security/jgss/GSSUtil.java
37 /**
38 * Do not call.
39 */
40 @Deprecated(since="16", forRemoval=true)
41 public GSSUtil() {}
Is your concern that there may be some code out there
Hi Sean,
On 7/24/2020 4:52 AM, Sean Mullan wrote:
Hi Joe,
On 7/24/20 1:17 AM, Joe Darcy wrote:
Hello,
Please review a set of changes to add explicit constructors to
replace default (implicit) constructors in various classes in
security libs across several modules:
JDK-8250246:
I'd suggest changing
+result = isSigning ? rb.getString("jar.signed.") :
rb.getString("jar.verified.");
+if ((strict) && (!errors.isEmpty())) {
+result = isSigning ? rb.getString("jar.signed.with.signer.errors.")
+ :
Hi Joe,
On 7/24/20 1:17 AM, Joe Darcy wrote:
Hello,
Please review a set of changes to add explicit constructors to replace
default (implicit) constructors in various classes in security libs
across several modules:
JDK-8250246: Address reliance on default constructors in security libs
> On Jul 15, 2020, at 12:16 AM, Weijun Wang wrote:
>
> The following lines are useless now:
>
Ok, this is a separate problem from the original bug to be addressed.
Cleanup/refactoring of the checking on flags is also included in this changeset.
> 1053 if (badKeyUsage ||
