Re: [16] RFR JDK-8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider

2020-08-18 Thread Xuelei Fan
On 8/18/2020 2:43 PM, Valerie Peng wrote: Using a shared instance is surely faster. However, the API specified that the most preferred SecureRandom impl will be used. To ensure this for all scenarios, creating default SecureRandom obj will provide correct result but shared instance may not. I

Re: [16] RFR JDK-8172366: Support SHA-3 based signatures

2020-08-18 Thread Valerie Peng
Thanks for the feedback~ Valerie On 8/18/2020 1:30 PM, Jamil Nimeh wrote: From just a quick skimming across a few FIPS specs, it looks like DSA with SHA-3 seems worth including.  FIPS 202 is designed to supplement the hash algs in 180-4, and Section 2.3 of 186-4 indicates that SHAx(M) is inte

Re: [16] RFR JDK-8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider

2020-08-18 Thread Valerie Peng
Using a shared instance is surely faster. However, the API specified that the most preferred SecureRandom impl will be used. To ensure this for all scenarios, creating default SecureRandom obj will provide correct result but shared instance may not. Apps can call other init functions which t

Re: [16] RFR JDK-8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider

2020-08-18 Thread Xuelei Fan
Is there any performance impact? Xuelei On 8/18/2020 12:51 PM, Valerie Peng wrote: Anyone has cycles to review this somewhat trivial changes? JceSecurity has this shared SecureRandom instance which may lead to NPE when certain 3rd party JCE provider is set as most preferred. Removing this sh

Re: [16] RFR JDK-8172366: Support SHA-3 based signatures

2020-08-18 Thread Jamil Nimeh
From just a quick skimming across a few FIPS specs, it looks like DSA with SHA-3 seems worth including.  FIPS 202 is designed to supplement the hash algs in 180-4, and Section 2.3 of 186-4 indicates that SHAx(M) is intended for those algs specified in 180 (and I assume by extension 202).  Since

[16] RFR JDK-8172366: Support SHA-3 based signatures

2020-08-18 Thread Valerie Peng
Can someone help review this SHA-3 based signature support? Note that changes to SunPKCS11 provider will be covered by a separate RFE (JDK-8244154). Current webrev adds SHA-3 digest support to DSA, RSA, ECDSA signature algorithms. I am a bit on the fence for the DSA signature and am includin

[16] RFR JDK-8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider

2020-08-18 Thread Valerie Peng
Anyone has cycles to review this somewhat trivial changes? JceSecurity has this shared SecureRandom instance which may lead to NPE when certain 3rd party JCE provider is set as most preferred. Removing this shared instance and change to create default SecureRandom obj when needed. Bug: http

Re: Fix for Javadoc errors in java.base

2020-08-18 Thread Mandy Chung
Looks fine. Thanks Mandy On 8/18/20 10:02 AM, Julia Boes wrote: Hi, The two changes below still need to be reviewed. Any takers? Cheers, Julia --- old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14 23:55:41.953638446 +0530 +++ new/src/jav

Re: Fix for Javadoc errors in java.base

2020-08-18 Thread Julia Boes
Hi, The two changes below still need to be reviewed. Any takers? Cheers, Julia --- old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14 23:55:41.953638446 +0530 +++ new/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafa