On Tue, 8 Dec 2020 22:16:30 GMT, Christoph Langer wrote:
>> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java line 61:
>>
>>> 59: System.out.println("FDs in the end: " + fds_end);
>>> 60:
>>> 61: if ((fds_end - fds_start) > (NUM_TEST_SOCK /
>>>
On Tue, 8 Dec 2020 16:27:19 GMT, Xue-Lei Andrew Fan wrote:
>> The test sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java caused sporadic
>> noise because sometimes it opens more file handles than expected. It was
>> moved to a manual test to quiesce this
>>
> This is a spec change with noreg-doc label.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
updated spec text and included typo fix
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1701/files
- new:
On Tue, 8 Dec 2020 20:24:51 GMT, Sean Mullan wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated with implSpec tag
>
> src/java.base/share/classes/java/security/KeyStoreSpi.java line 323:
>
>> 321: *
On Tue, 8 Dec 2020 20:16:35 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/KeyStoreSpi.java line 322:
>>
>>> 320: * @throwsCertificateException if any of the certificates
>>> included in
>>> 321: * the keystore data could not be stored
>>> 322:
On Tue, 8 Dec 2020 18:36:15 GMT, Hai-May Chao wrote:
>> This is a spec change with noreg-doc label.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated with implSpec tag
> This is a spec change with noreg-doc label.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
white space after throw tag added
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1701/files
- new:
On Tue, 8 Dec 2020 18:42:16 GMT, Xue-Lei Andrew Fan wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated with implSpec tag
>
> src/java.base/share/classes/java/security/KeyStoreSpi.java line 322:
>
>> 320:
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Tue, 8 Dec 2020 18:42:22 GMT, Xue-Lei Andrew Fan wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated with implSpec tag
>
> Marked as reviewed by xuelei (Reviewer).
This will also require a CSR since you
On Tue, 8 Dec 2020 17:52:34 GMT, Hai-May Chao wrote:
> This is a spec change with noreg-doc label.
There is a "Title mismatch between PR and JBS" issue. I think it could be
solved by use the same title/subject for the pull request and bug in JBS.
-
PR:
On Tue, 8 Dec 2020 18:36:15 GMT, Hai-May Chao wrote:
>> This is a spec change with noreg-doc label.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated with implSpec tag
Marked as reviewed by xuelei (Reviewer).
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Tue, 8 Dec 2020 18:08:38 GMT, Xue-Lei Andrew Fan wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated with implSpec tag
>
> src/java.base/share/classes/java/security/KeyStoreSpi.java line 319:
>
>> 317:
> This is a spec change with noreg-doc label.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
Updated with implSpec tag
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1701/files
- new:
On Tue, 8 Dec 2020 18:16:15 GMT, Mandy Chung wrote:
>> @wangweij Moving build tools is a related, but separate, question, which is
>> addressed by https://bugs.openjdk.java.net/browse/JDK-8241463.
>>
>> I send out a review earlier this year (see
>>
On Tue, 8 Dec 2020 16:19:05 GMT, Magnus Ihse Bursie wrote:
>> Is there a plan to move make/jdk/src/classes/build/tools/intpoly into
>> java.base as well?
>>
>> Update: I see all subdirs in tools are still there.
>
> @wangweij Moving build tools is a related, but separate, question, which is
>
On Tue, 8 Dec 2020 17:52:34 GMT, Hai-May Chao wrote:
> This is a spec change with noreg-doc label.
src/java.base/share/classes/java/security/KeyStoreSpi.java line 319:
> 317: * @throwsCertificateException if any of the certificates
> included in
> 318: * the keystore
This is a spec change with noreg-doc label.
-
Commit messages:
- 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch to its
behavior
Changes: https://git.openjdk.java.net/jdk/pull/1701/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1701=00
Issue:
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
On Tue, 8 Dec 2020 07:27:07 GMT, Christoph Langer wrote:
> The test sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java caused sporadic
> noise because sometimes it opens more file handles than expected. It was
> moved to a manual test to quiesce this
>
On Tue, 8 Dec 2020 14:56:20 GMT, Andy Herrick wrote:
>> Looks like test failed due to:
>> [Fatal Error] b.wxl:3:1: XML document structures must start and end within
>> the same entity.
>> So, I am not sure how increased repeat will help. Do we know why it failed
>> to parse XML?
>
>>
>>
>>
On Tue, 8 Dec 2020 15:25:47 GMT, Weijun Wang wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
> increase retries and timeout increasing in runMsiexecWithRetries
Andy Herrick has updated the pull request incrementally with 18 additional
commits since the last revision:
- 8256149: Weird AST structure for incomplete member select
Reviewed-by: vromero
- 8257194: Add 'foreign linker
On 2020-12-08 00:30, Magnus Ihse Bursie wrote:
On Tue, 8 Dec 2020 02:40:43 GMT, Mandy Chung wrote:
I have reviewed all lines in the patch file with or near instances of
`jdk.compiler`
Hi Magnus,
I see the motivation of moving these build files for better identification of
ownership.
On Tue, 8 Dec 2020 08:32:28 GMT, Magnus Ihse Bursie wrote:
>> @mlchung If you don't have any strong preference, I implore you to accept
>> this change. I **vastly** prefer to move the data out of `make`!
>>
>> This is not just about Skara tooling. When working with make files, autoconf
>> and
On Tue, 8 Dec 2020 08:27:16 GMT, Magnus Ihse Bursie wrote:
>> Hi Magnus,
>>
>> I see the motivation of moving these build files for better identification
>> of ownership. Placing them under
>> `src/$MODULE/{share,$OS}/data` is one option. Given that skara will
>> automatically determine
On Tue, 8 Dec 2020 02:40:43 GMT, Mandy Chung wrote:
>> I have reviewed all lines in the patch file with or near instances of
>> `jdk.compiler`
>
> Hi Magnus,
>
> I see the motivation of moving these build files for better identification of
> ownership. Placing them under
>
30 matches
Mail list logo
