There are some boolean expressions that could be improved for better
readability in the SunJSSE provider implementation. For example:
- if (cert instanceof X509Certificate == false) {
+ if (!(cert instanceof X509Certificate)) {
- return isDTLS ? true : (id >= TLS10.id);
+ return isDTLS || (id
On Mon, 4 Jan 2021 18:06:24 GMT, Xue-Lei Andrew Fan wrote:
> There are a few fields in the SunJSSE provider implementation could be final.
>
> Code clean up to easy the maintenance, no new test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8259069
This pull request has now been integrated
On Mon, 28 Dec 2020 16:24:43 GMT, Martin Balao wrote:
> When a multi-part cipher operation fails in SunPKCS11 (i.e. because of an
> invalid block size), we now cancel the operation before returning the
> underlying Session to the Session Manager. This allows to use the returned
> Session for a
On Tue, 15 Dec 2020 22:56:15 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Mon, 4 Jan 2021 18:06:24 GMT, Xue-Lei Andrew Fan wrote:
> There are a few fields in the SunJSSE provider implementation could be final.
>
> Code clean up to easy the maintenance, no new test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8259069
Marked as reviewed by wetmore (Reviewer).
On Mon, Jan 4, 2021 at 8:34 AM Peter Levart
wrote:
>
> On Mon, 4 Jan 2021 15:57:33 GMT, Richard Reingruber
wrote:
>
> >> The bug title and the PR title need to be the same.
> >> Editing either one is fine.
> >
> > But wouldn't it be legal for a compiler (java to bytecode or bytecode to
> > machin
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
> http://cr.openjdk.java.net/~jlaskey/prng/doc/a
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote:
>> See: https://bugs.openjdk.java.net/browse/JDK-8259021
>> See also discussion in thread:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html
>
> Peter Levart has updated the pull request incrementally with one
On Mon, 4 Jan 2021 17:45:25 GMT, Mandy Chung wrote:
>> Peter Levart has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert the unrelated change
>
> Marked as reviewed by mchung (Reviewer).
>
>
> _Mailing list message from [Hans Boehm]
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote:
>> See: https://bugs.openjdk.java.net/browse/JDK-8259021
>> See also discussion in thread:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html
>
> Peter Levart has updated the pull request incrementally with one
There are a few fields in the SunJSSE provider implementation could be final.
Code clean up to easy the maintenance, no new test.
Bug: https://bugs.openjdk.java.net/browse/JDK-8259069
-
Commit messages:
- 8259069: Fields could be final
Changes: https://git.openjdk.java.net/jdk/pul
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote:
>> See: https://bugs.openjdk.java.net/browse/JDK-8259021
>> See also discussion in thread:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html
>
> Peter Levart has updated the pull request incrementally with one
On Mon, 4 Jan 2021 15:57:33 GMT, Richard Reingruber wrote:
>> The bug title and the PR title need to be the same.
>> Editing either one is fine.
>
> But wouldn't it be legal for a compiler (java to bytecode or bytecode to
> machinecode) to replace references of my_local_copy with references to
>
On Mon, 4 Jan 2021 15:11:27 GMT, Roger Riggs wrote:
>> Peter Levart has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert the unrelated change
>
> The bug title and the PR title need to be the same.
> Editing either one is fine.
But wo
On Tue, 15 Dec 2020 22:56:15 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote:
>> See: https://bugs.openjdk.java.net/browse/JDK-8259021
>> See also discussion in thread:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html
>
> Peter Levart has updated the pull request incrementally with one
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote:
>> See: https://bugs.openjdk.java.net/browse/JDK-8259021
>> See also discussion in thread:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html
>
> Peter Levart has updated the pull request incrementally with one
> See: https://bugs.openjdk.java.net/browse/JDK-8259021
> See also discussion in thread:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html
Peter Levart has updated the pull request incrementally with one additional
commit since the last revision:
revert the unr
On Wed, 18 Nov 2020 13:45:12 GMT, Jim Laskey wrote:
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be foun
On Thu, 31 Dec 2020 10:02:01 GMT, Peter Levart wrote:
> See: https://bugs.openjdk.java.net/browse/JDK-8259021
> See also discussion in thread:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html
Looks good, but can we not do the behavioral change in
`ensureClassIn
20 matches
Mail list logo
