Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-01-28 Thread Xue-Lei Andrew Fan
On Thu, 28 Jan 2021 20:12:14 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v14]

2021-01-28 Thread Mark Reinhold
On Mon, 18 Jan 2021 16:45:00 GMT, Jim Laskey wrote: >> This PR is to introduce a new random number API for the JDK. The primary API >> is found in RandomGenerator and RandomGeneratorFactory. Further description >> can be found in the JEP https://openjdk.java.net/jeps/356 . >> >> javadoc can

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-01-28 Thread Clive Verghese
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears > to not be fully fixed > > This also fixes JDK-8259516: Alerts sent by peer may not be received > correctly during TLS handshake Clive Verghese has updated the pull request incrementally with one additional commit

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-28 Thread Xue-Lei Andrew Fan
On Tue, 26 Jan 2021 18:56:57 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has

Re: RFR: 8256421: Add 2 HARICA roots to Oracle Root CA Program

2021-01-28 Thread Hai-May Chao
On Thu, 28 Jan 2021 01:22:52 GMT, Rajan Halade wrote: > Following two roots are added to cacerts store - > > CN=Hellenic Academic and Research Institutions RootCA 2015, O=Hellenic > Academic and Research Institutions Cert. Authority, L=Athens, C=GR > > CN=Hellenic Academic and Research

Re: RFR: 8256421: Add 2 HARICA roots to Oracle Root CA Program

2021-01-28 Thread Rajan Halade
On Thu, 28 Jan 2021 18:13:39 GMT, Hai-May Chao wrote: > Looks good. Thanks!! Can you please approve review with approval on changeset? With that, your OpenJDK id will be added as reviewer to the fix. - PR: https://git.openjdk.java.net/jdk/pull/2272

Re: RFR: 8256421: Add 2 HARICA roots to Oracle Root CA Program

2021-01-28 Thread Hai-May Chao
On Thu, 28 Jan 2021 01:22:52 GMT, Rajan Halade wrote: > Following two roots are added to cacerts store - > > CN=Hellenic Academic and Research Institutions RootCA 2015, O=Hellenic > Academic and Research Institutions Cert. Authority, L=Athens, C=GR > > CN=Hellenic Academic and Research

Re: RFR: 8258915: Temporary buffer cleanup [v5]

2021-01-28 Thread Weijun Wang
> Clean up temporary byte array, char array, and keyspec around keys and > passwords. > > No new regression test. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: cleanups for key generations - Changes: - all:

Re: RFR: 8258915: Temporary buffer cleanup

2021-01-28 Thread Weijun Wang
On Fri, 22 Jan 2021 21:25:25 GMT, Weijun Wang wrote: >> New commit. However, I was writing test to detect leak in >> `RSAPrivateKeySpec` conversion and add more key->spec->key for other >> algorithms and find more leaks. Will fix in another commit. > > Another new commit. Last time I only

Re: RFR: 8259801: Enable XML Signature secure validation mode by default [v2]

2021-01-28 Thread Sean Mullan
> This change enables the XML Signature secure validation mode by default. This > will improve out of the box security by restricting signatures that contain > potentially unsafe content by default. > > Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8260154 Sean Mullan

Integrated: 8259801: Enable XML Signature secure validation mode by default

2021-01-28 Thread Sean Mullan
On Fri, 22 Jan 2021 17:23:12 GMT, Sean Mullan wrote: > This change enables the XML Signature secure validation mode by default. This > will improve out of the box security by restricting signatures that contain > potentially unsafe content by default. > > Please also review the CSR:

RFR: Release Note for 8259801: Enable XML Signature secure validation mode by default

2021-01-28 Thread Sean Mullan
Please review the release note for JDK-8259801: https://bugs.openjdk.java.net/browse/JDK-8260551 Thanks, Sean