On Tue, 2 Mar 2021 21:19:18 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Fri, 19 Feb 2021 08:39:23 GMT, John Jiang wrote:
> Similar to the constructor SNIHostName(String hostname), the constructor
> SNIHostName(byte[] encoded) also needs to check if the encoded hostname
> conform to RFC 3490.
This pull request has now been integrated.
Changeset: 4f4d0f53
Author
On Tue, 2 Mar 2021 21:36:36 GMT, Rajan Halade wrote:
>> John Jiang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Throw RuntimeException instead of Exception
>
> Thanks for updating the test.
@rhalade @XueleiFan Thanks for your reviews
On Tue, 23 Feb 2021 02:10:58 GMT, John Jiang wrote:
>> Similar to the constructor SNIHostName(String hostname), the constructor
>> SNIHostName(byte[] encoded) also needs to check if the encoded hostname
>> conform to RFC 3490.
>
> John Jiang has updated the pull request incrementally with one a
On Tue, 23 Feb 2021 02:10:58 GMT, John Jiang wrote:
>> Similar to the constructor SNIHostName(String hostname), the constructor
>> SNIHostName(byte[] encoded) also needs to check if the encoded hostname
>> conform to RFC 3490.
>
> John Jiang has updated the pull request incrementally with one a
On Thu, 4 Feb 2021 22:58:39 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Mon, 22 Feb 2021 21:31:21 GMT, Xue-Lei Andrew Fan wrote:
>> Actually there's a much easier solution to reduce the number of slow
>> `put()`s without making any behavioral changes.
>> The cache object could store the earliest expire time, and then exit
>> `expungeExpiredEntries()` early when
On Fri, 12 Feb 2021 15:21:06 GMT, Vladimir Kempik wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 302:
>>
>>> 300: const uint64_t *detail_msg_ptr
>>> 301: = (uint64_t*)(pc + NativeInstruction::instruction_size);
>>> 302: const char *detail_msg = (const
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
> Under certain load, MemoryCache operations take a substantial fraction of the
> time needed to complete SSL handshakes. This series of patches improves
> performance characteristics of MemoryCache, at the cost of a functional
> change: expired entries are no longer guaranteed to be removed bef
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
On Thu, 4 Feb 2021 22:34:16 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
Hello,
Actually, in HTML was a separator, and in xhtml it should enclose
paragraphs. However I was under the impression Javadoc always used the
separator style (it would be strange to start the first sentence in Javadoc
with . Is this doccheck enforcing a new policy?
This officially Oracle gu
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
Please review some minor doc fixes, for issues found by _doccheck_.There
are two kinds of errors that are addressed.
1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph.
It is not a terminator, to mark the end of a paragraph, or a separator to mark
the boundary between
On Tue, 2 Mar 2021 17:26:15 GMT, Ziyi Luo wrote:
>> All of the "isAssignableFrom" checks in "engineGetKeySpec" appear to be
>> backwards in Java's KeyFactorySpi.engineGetKeySpec implementations. In most
>> cases, the requested KeySpec is equal to the concrete implementation so the
>> inversion
On Wed, 24 Feb 2021 02:40:36 GMT, Jamil Nimeh wrote:
>> Ziyi Luo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear
>> to be backwards (r2)
>
> test/jdk/java/securit
On Wed, 24 Feb 2021 02:39:57 GMT, Jamil Nimeh wrote:
>> All of the "isAssignableFrom" checks in "engineGetKeySpec" appear to be
>> backwards in Java's KeyFactorySpi.engineGetKeySpec implementations. In most
>> cases, the requested KeySpec is equal to the concrete implementation so the
>> inver
> All of the "isAssignableFrom" checks in "engineGetKeySpec" appear to be
> backwards in Java's KeyFactorySpi.engineGetKeySpec implementations. In most
> cases, the requested KeySpec is equal to the concrete implementation so the
> inversion does not matter. But there are few cases, as presented
On Tue, 9 Feb 2021 19:54:43 GMT, Anthony Scarpino wrote:
> Hi,
>
> I need a review of these two simple fixes. One just sets the input
> bytebuffer position to the limit upon completion of decryption. The second
> calls the CipherCore method to clear the state from the previous operation.
>
On Tue, 2 Mar 2021 15:08:01 GMT, Evan Whelan wrote:
>> Hi all,
>>
>> Please review my test fix relating to JDK-8262438
>>
>> This patch introduces as Thread.sleep at the start of each iteration which
>> creates a new test jvm.
>> This allows the server socket sufficient time to release the pr
On Fri, 26 Feb 2021 17:17:09 GMT, Daniel Fuchs wrote:
>> Hi all,
>>
>> Please review my test fix relating to JDK-8262438
>>
>> This patch introduces as Thread.sleep at the start of each iteration which
>> creates a new test jvm.
>> This allows the server socket sufficient time to release the
> Hi all,
>
> Please review my test fix relating to JDK-8262438
>
> This patch introduces as Thread.sleep at the start of each iteration which
> creates a new test jvm.
> This allows the server socket sufficient time to release the previous
> connection and allows the port to be used again.
>
On Thu, 4 Feb 2021 22:15:47 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Wed, 10 Feb 2021 15:06:35 GMT, Martin Balao wrote:
> Hi,
>
> I'd like to propose a fix for JDK-8261355 [1].
>
> The scheme used for holding data and padding while performing encryption
> operations is almost the same than the existing one for decryption. The only
> difference is that encry
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
> http://cr.openjdk.java.net/~jlaskey/prng/doc/a
On Tue, 2 Feb 2021 23:10:17 GMT, Daniel D. Daugherty wrote:
> For platform files that were copied from other ports to this port, if the
> file wasn't
> changed I presume the copyright years are left alone. If the file required
> changes
> for this port, I expect the year to be updated to 2021.
On Fri, 26 Feb 2021 11:12:08 GMT, Abdul Kolarkunnu
wrote:
> There is a lack of tests in the area of java.net.Socket.shutdownInput() and
> java.net.Socket.shutdownOutput() , so added more tests in this area of with
> different TLS versions. Please review.
@coffeys
-
PR: https://
On Tue, 2 Feb 2021 22:47:04 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/prims/nativeEntryPoint.cpp line 45:
>
>> 43: guarantee(st
On Tue, 2 Feb 2021 22:18:43 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/thread_bsd_aarch64.cpp line 43:
>
>> 41: ass
On Fri, 12 Feb 2021 13:32:52 GMT, Vladimir Kempik wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 486:
>>
>>> 484: }
>>> 485: }
>>> 486: }
>>
>> This appears to be a mix for Mavericks (10.9) and 10.12
>> work arounds. Is this code needed by this project?
>
> I
On Fri, 12 Feb 2021 12:40:09 GMT, Florian Weimer wrote:
>> only macos comiplers
>
> The comment is also wrong for glibc: The AArch64 ABI requires a 64 KiB guard
> region independently of page size, otherwise `-fstack-clash-protection` is
> not reliable.
Thanks, I deleted the comment. It descri
34 matches
Mail list logo
