Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Vladimir Ivanov
On Wed, 12 May 2021 15:07:37 GMT, Maurizio Cimadamore wrote: >> src/hotspot/share/runtime/sharedRuntime.hpp line 465: >> >>> 463: static void restore_native_result(MacroAssembler *_masm, BasicType >>> ret_type, int frame_slots); >>> 464: >>> 465: static void move32_64(MacroAssembler* ma

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-12 Thread David Black
Hi, I hope it is okay if I provide another example/use case & view here. On Thu, 13 May 2021 at 07:49, Ron Pressler wrote: > > > > On 12 May 2021, at 22:41, Peter Tribble wrote: > > > > > > Let me give a concrete example: > > > > Parsing and rendering a PDF file that may contain references to f

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-12 Thread Peter Firmstone
Ron, Can JEP 411 be targeted against Java 18 please? I realize long term support is not OpenJDK's concern, however other's are planning Java 17 to be a long term support release and that will impact us. Thank you, Peter Firmstone Zeus Project Services Pty Ltd. On 13/05/2021 7:43 am, Ron Pr

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation [v2]

2021-05-12 Thread Valerie Peng
> Anyone can help review this somewhat trivial fix? The main change is inside > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to > help better troubleshooting by reporting the type of unavailable attributes > in PKCS11 exception message when C_GetAttributeValue(...) cal

Re: [External] : Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-12 Thread Ron Pressler
P.S. Sorry, I just realised I used the word “process” in 1 and 2 with different meanings. In 1 I meant an OS process running Java; in 2 I merely meant a Java mechanism (as opposed to an OS mechanism). > On 12 May 2021, at 22:49, Ron Pressler wrote: > > > >> On 12 May 2021, at 22:41, Peter

Re: [External] : Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-12 Thread Ron Pressler
> On 12 May 2021, at 22:41, Peter Tribble wrote: > > > Let me give a concrete example: > > Parsing and rendering a PDF file that may contain references to fonts or > other resources. > We know exactly where the files are installed, so wish to allow the rendering > routine access > to the fo

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-12 Thread Ron Pressler
> On 8 May 2021, at 05:55, Peter Firmstone wrote: > > What would help in future: > > • Define a core Java api, a javadoc annotation? If parts of it are > deprecated, they will not be removed for eg 3 LTS releases, pick a number, it > provides certainty. Developers writing new software

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-12 Thread Peter Tribble
On Wed, May 12, 2021 at 10:22 PM Ron Pressler wrote: > > > > On 12 May 2021, at 21:46, Peter Tribble wrote: > > > > We're (partly, at least) in that group. We can't block the access from > outside > > the JVM (and we are containerized with restricted permissions already) > because > > some acces

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Vladimir Ivanov
On Wed, 12 May 2021 14:53:39 GMT, Jorn Vernee wrote: >> src/hotspot/cpu/x86/universalUpcallHandler_x86_64.cpp line 472: >> >>> 470: __ block_comment("} preserve_callee_saved_regs "); >>> 471: >>> 472: // TODO mxcsr >> >> Anything left to do with mxcsr? > > I guess this slipped through with

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-12 Thread Ron Pressler
> On 12 May 2021, at 21:46, Peter Tribble wrote: > > We're (partly, at least) in that group. We can't block the access from outside > the JVM (and we are containerized with restricted permissions already) because > some accesses are legitimate - something outside the JVM doesn't know when > the

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-12 Thread Peter Tribble
On Thu, May 6, 2021 at 12:48 PM Alan Bateman wrote: > On 06/05/2021 11:26, Peter Firmstone wrote: > > > > OpenJDK seems to have assumed that no one was using SecurityManager > > based on one research report. > > > I don't think this is right. Instead I would say that many of us have > rarely enco

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider [v2]

2021-05-12 Thread Valerie Peng
On Fri, 7 May 2021 13:51:05 GMT, Sean Coffey wrote: >> Added capability to allow the PKCS11 Token to be destroyed once a session is >> logged out from. New configuration properties via pkcs11 config file. >> Cleaned up the native resource poller also. >> >> New unit test case to test behaviour

Re: RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java

2021-05-12 Thread Hai-May Chao
On Tue, 11 May 2021 04:22:49 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have the following test code reviewed? > > The test SSLEngineExplorerMatchedSNI.java fails intermittently. I tried to > run the test 500 times, but cannot reproduce the issue. The cause is unknown > to me now. It wo

Re: RFR: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption [v3]

2021-05-12 Thread Rajan Halade
On Tue, 11 May 2021 13:58:28 GMT, Fernando Guallini wrote: >> test sun/security/ssl/SSLSocketImpl/CloseSocket.java verifies the behavior >> when a server closes the socket connection during a handshake. The server >> was waiting a fixed 100ms before closing it, but there was no guarantee that

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Maurizio Cimadamore
On Wed, 12 May 2021 13:57:21 GMT, Vladimir Ivanov wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> * Remove unused imports >> * Fix broken javadoc after removal of @throws clauses >> * Remove other `@Call

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Jorn Vernee
On Wed, 12 May 2021 14:06:46 GMT, Vladimir Ivanov wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> * Remove unused imports >> * Fix broken javadoc after removal of @throws clauses >> * Remove other `@Call

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Vladimir Ivanov
On Mon, 10 May 2021 20:43:20 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-412 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Vladimir Ivanov
On Mon, 10 May 2021 20:43:20 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-412 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

AW: [11u] RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms

2021-05-12 Thread Doerr, Martin
Hi Paul, thank you for the review! I´ll remove the extra blank line before pushing. Best regards, Martin Von: Hohensee, Paul Datum: Mittwoch, 12. Mai 2021 um 00:00 An: Doerr, Martin , jdk-updates-...@openjdk.java.net , security-dev Cc: Langer, Christoph Betreff: Re: [11u] RFR: 8153005: Upgr

Re: Performance differences between Java 8,, 11, 14 and 16

2021-05-12 Thread Peter Firmstone
Hi Alan, Understood, not sure if I could give AccessController that kind of workout using JDK classes alone, the library code is very performant.   It might be possible if AllPermission is granted and ClassLoaders are created using only class bytes, without accessing files, to avoid using the

Re: Performance differences between Java 8,, 11, 14 and 16

2021-05-12 Thread Alan Bateman
On 12/05/2021 07:18, Peter Firmstone wrote: https://github.com/pfirmstone/JGDMS/blob/trunk/qa/src/org/apache/river/test/impl/mahalo/RandomStressTest.java https://github.com/pfirmstone/JGDMS/blob/trunk/qa/src/org/apache/river/test/impl/mahalo/RandomStressTest.td It would be great if there wer

Re: Performance differences between Java 8,, 11, 14 and 16

2021-05-12 Thread Peter Firmstone
Steps to reproduce: Use git to checkout https://github.com/pfirmstone/JGDMS.git Set the following path variables to your Java installation directory: JAVA_HOME=file path to java 8 JDK_HOME=file path to jdk 8 (same as above) Make sure the java command returns Java 8. $java -version Change di