On Tue, 27 Jul 2021 03:51:01 GMT, Mandy Chung wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Additional codereview comments
>
> src/java.base/share/classes/javax/crypto/JceSecurityManager.java line 76:
>
>> 7
> The JceSecurityManager is currently a subclass of
> java.security.SecurityManager. Now that JEP 411 has been integrated, this
> class should be updated to no longer subclass SecurityManager.
>
> The only reason for using SecurityManager to easily get the Class Context
> (call stack), but we
On Tue, 27 Jul 2021 02:50:54 GMT, Bradford Wetmore wrote:
>> The JceSecurityManager is currently a subclass of
>> java.security.SecurityManager. Now that JEP 411 has been integrated, this
>> class should be updated to no longer subclass SecurityManager.
>>
>> The only reason for using Securit
> The JceSecurityManager is currently a subclass of
> java.security.SecurityManager. Now that JEP 411 has been integrated, this
> class should be updated to no longer subclass SecurityManager.
>
> The only reason for using SecurityManager to easily get the Class Context
> (call stack), but we
> The JceSecurityManager is currently a subclass of
> java.security.SecurityManager. Now that JEP 411 has been integrated, this
> class should be updated to no longer subclass SecurityManager.
>
> The only reason for using SecurityManager to easily get the Class Context
> (call stack), but we
On Thu, 22 Jul 2021 18:30:50 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 762:
>>
>>> 760:
>>> 761: dst.put(out, 0, rlen);
>>> 762: processed += srcLen;
>>
>> It seems that callers of this implGCMCr
On Mon, 14 Jun 2021 17:00:29 GMT, Andrey Turbanov
wrote:
> I found few places, where code initially perform `Object[]
> Colleciton.toArray()` call and then manually copy array into another array
> with required type.
> This PR cleanups such places to more shorter call `T[]
> Collection.toArra
On Mon, 14 Jun 2021 17:00:29 GMT, Andrey Turbanov
wrote:
> I found few places, where code initially perform `Object[]
> Colleciton.toArray()` call and then manually copy array into another array
> with required type.
> This PR cleanups such places to more shorter call `T[]
> Collection.toArra
On Mon, 14 Jun 2021 17:00:29 GMT, Andrey Turbanov
wrote:
> I found few places, where code initially perform `Object[]
> Colleciton.toArray()` call and then manually copy array into another array
> with required type.
> This PR cleanups such places to more shorter call `T[]
> Collection.toArra
On Wed, 21 Jul 2021 02:02:06 GMT, Rajan Halade wrote:
> This CA had no code signing certificates issued so it is safe to remove it
> from cacerts truststore.
Marked as reviewed by mullan (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4851
On Mon, 26 Jul 2021 17:03:11 GMT, Sean Mullan wrote:
>> Please review this fix to change the internal `X509CertImpl.getFingerprint`
>> method to not return "" as a fingerprint if there is an error generating
>> that fingerprint. Instead, `null` is now returned, and "" is no longer
>> cached as
On Mon, 14 Jun 2021 11:34:50 GMT, Andrey Turbanov
wrote:
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if a thread-safe implementation is not needed. In
> post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I check
On Mon, 26 Jul 2021 14:12:48 GMT, Weijun Wang wrote:
>> Not sure what you mean by inline. Do you mean use an anonymous inner class
>> instead of a lambda for the `Function` argument to
>> `ConcurrentHashMap.computeIfAbsent`? Note that `getFingerprintInternal`
>> calls `this.getEncodedInternal`
> Please review this fix to change the internal `X509CertImpl.getFingerprint`
> method to not return "" as a fingerprint if there is an error generating that
> fingerprint. Instead, `null` is now returned, and "" is no longer cached as a
> valid fingerprint. Although errors generating fingerprin
On Mon, 26 Jul 2021 13:37:39 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 1924:
>>
>>> 1922: x -> getFingerprintInternal(x, debug));
>>> 1923: }
>>> 1924:
>>
>> I'm a little confused by these methods. Can you inline
>> `getFin
On Fri, 23 Jul 2021 22:18:26 GMT, Weijun Wang wrote:
>> Please review this fix to change the internal `X509CertImpl.getFingerprint`
>> method to not return "" as a fingerprint if there is an error generating
>> that fingerprint. Instead, `null` is now returned, and "" is no longer
>> cached as
On Mon, 14 Jun 2021 17:00:29 GMT, Andrey Turbanov
wrote:
> I found few places, where code initially perform `Object[]
> Colleciton.toArray()` call and then manually copy array into another array
> with required type.
> This PR cleanups such places to more shorter call `T[]
> Collection.toArra
On Tue, 15 Jun 2021 12:34:50 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/java/security/Security.java line 656:
>>
>>> 654: return null;
>>> 655:
>>> 656: return candidates.toArray(new Provider[0]);
>>
>> `candidates.toArray(new Provider[candidates.size()]);`
On Mon, 14 Jun 2021 17:00:29 GMT, Andrey Turbanov
wrote:
> I found few places, where code initially perform `Object[]
> Colleciton.toArray()` call and then manually copy array into another array
> with required type.
> This PR cleanups such places to more shorter call `T[]
> Collection.toArra
On Mon, 14 Jun 2021 17:00:29 GMT, Andrey Turbanov
wrote:
> I found few places, where code initially perform `Object[]
> Colleciton.toArray()` call and then manually copy array into another array
> with required type.
> This PR cleanups such places to more shorter call `T[]
> Collection.toArra
On Tue, 15 Jun 2021 12:06:43 GMT, Michael Bien
wrote:
>> I found few places, where code initially perform `Object[]
>> Colleciton.toArray()` call and then manually copy array into another array
>> with required type.
>> This PR cleanups such places to more shorter call `T[]
>> Collection.toAr
I found few places, where code initially perform `Object[]
Colleciton.toArray()` call and then manually copy array into another array with
required type.
This PR cleanups such places to more shorter call `T[] Collection.toArray(T[])`.
-
Commit messages:
- Replace usages of Collecti
On Wed, 21 Jul 2021 02:02:06 GMT, Rajan Halade wrote:
> This CA had no code signing certificates issued so it is safe to remove it
> from cacerts truststore.
Looks like a clean removal to me. Approving so this can be backported to JDK
Updates that would be after the cert expiry date.
23 matches
Mail list logo
