RFR 8207783: PoodleSSLv3 test update for TLSv1.2 and TLSv1.3

Hi All, Please help to review the changeset below, which update PoodleSSLv3 test for newer protocol versions http://sqeweb.us.oracle.com/net/scanas415/export/corelibs/users/amjiang/webrev/8207783/webrev.00/ Thanks, Amanda

RFR 8190333: sun/security/ssl/X509KeyManager/PreferredKey.java failed with "Failed to get the preferable key aliases"

Hi All, The changeset below updates an expired alias in keystore. Please help to review it. Bug: https://bugs.openjdk.java.net/browse/JDK-8190333 Webrev: http://cr.openjdk.java.net/~amjiang/8190333/webrev.00/ Thanks, Amanda

Re: RFR 8176354: sun/security/ssl/X509KeyManager/PreferredKey.java failed with "Failed to get the preferable key aliases" error

Thank you for reviewing this. - Amanda On 9/20/17 6:33 PM, Xuelei Fan wrote: Looks fine to me. Thanks, Xuelei On 9/20/2017 4:52 PM, Amanda Jiang wrote: Hi All, Please help to review following webrev for fixing a test issue: Bug: https://bugs.openjdk.java.net/browse/JDK-8176354 webrev

RFR 8176354: sun/security/ssl/X509KeyManager/PreferredKey.java failed with "Failed to get the preferable key aliases" error

Hi All, Please help to review following webrev for fixing a test issue: Bug: https://bugs.openjdk.java.net/browse/JDK-8176354 webrev: http://cr.openjdk.java.net/~amjiang/8176354/webrev.00/ Thanks, Amanda

RFR 8176400: Problemlist sun/security/ssl/X509KeyManager/PreferredKey.java due to JDK-8176354

Hi All, Could you please help to review the patch below? sun/security/ssl/X509KeyManager/PreferredKey.java failed on all platforms since related certificate in keystore has been expired. To fix the bug, the keystore should be carefully updated with new certificate since a lot of tests

RFR 8171423: Relocate /test/lib/security/SecurityTools.java

Hi All, Please help to review the webrev below, which moves the utility class SecurityTools to root repo. Bug: https://bugs.openjdk.java.net/browse/JDK-8171423 Webrev: http://cr.openjdk.java.net/~amjiang/8171423/webrev.00/ Thanks, Amanda

RFR 8075618: Create tests to check jarsigner work with multi-version jar

Hi All, Please help to review following changeset, which tests that jarsigner tool works with multi-release JAR files. Webrev: http://cr.openjdk.java.net/~amjiang/8075618/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8075618 Thanks, Amanda

Re: RFR 8169911: Enhanced tests for jarsigner -verbose -verify after JDK-8163304

anks Max On Nov 19, 2016, at 8:38 AM, Amanda Jiang <amanda.ji...@oracle.com> wrote: HI All, Please help to review following code change: webrev: http://cr.openjdk.java.net/~amjiang/8169911/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8169911 This change enhances

RFR 8169911: Enhanced tests for jarsigner -verbose -verify after JDK-8163304

HI All, Please help to review following code change: webrev: http://cr.openjdk.java.net/~amjiang/8169911/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8169911 This change enhances test case for JDK-8163304 by covering following cases: - Multiple signers (signed by jarsigner

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

in your review. Thanks, Rajan On 5/23/16 3:24 PM, Amanda Jiang wrote: Hi Valerie , Rajan, Thanks for reviewing the webrev. I have updaed UnsupportedProvider.java to check NSAE for SUN and OracleUcrypto providers. Other tests has been updated by Rajan's comments as well. Please check

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

tests have no provider checks. Rest of tests look fine to me. Note, I am not a official reviewer so please wait for official reviewer to integrate changes. Thanks, Rajan On 5/19/16 11:34 AM, Amanda Jiang wrote: Hi All, Please help to review tests for JEP287: SHA-3 Hash Alogrithms. BugID: https

RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Hi All, Please help to review tests for JEP287: SHA-3 Hash Alogrithms. BugID: https://bugs.openjdk.java.net/browse/JDK-8156059 Webrev: http://cr.openjdk.java.net/~amjiang/8156059/webrev.01/ Test Plan: https://bugs.openjdk.java.net/browse/JDK-8068855 Thanks, Amanda

Re: RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

Hi Max, I think it would be better to update Solaris.sh with same format of other scripts, please check the latest changeset: http://cr.openjdk.java.net/~amjiang/8153545/webrev.03/ JPRT run is completed and all 3 tests has been passed in all platforms ( except Login.sh is excluded from

Re: RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

s are recorded at bug : https://bugs.openjdk.java.net/browse/JDK-8153545 I will submit a JPRT run with latest 9-dev repo and my changesset, to make sure this fix will work on all platform. Thanks, Amanda Thanks, Max On Apr 9, 2016, at 8:20 AM, Amanda Jiang <amanda.ji...@oracle.com> wrote: Hi Max, Than

Re: RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

1] http://hg.openjdk.java.net/jdk9/dev/jdk/file/cac52c9da800/test/sun/security/pkcs11/PKCS11Test.java#l184 On Apr 8, 2016, at 1:09 PM, Amanda Jiang <amanda.ji...@oracle.com> wrote: Hi All, Please help to review following changeset which fixes test bug for sun/security/pkcs11/Provider/Logi

RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

Hi All, Please help to review following changeset which fixes test bug for sun/security/pkcs11/Provider/Login.sh and another similar failed test. Bug: https://bugs.openjdk.java.net/browse/JDK-8153545 Changest: http://cr.openjdk.java.net/~amjiang/8153545/webrev.01/ Thanks, Amanda

RFR 8143377: Test PKCS8Test.java fails

Hi Max, Could you please review the fixes below for a test bug? Bug: https://bugs.openjdk.java.net/browse/JDK-8143377 Webrev: http://cr.openjdk.java.net/~amjiang/8143377/webrev/ Thanks, Amanda

Re: RFR 8143377: Test PKCS8Test.java fails

jan On 11/24/15 2:05 PM, Amanda Jiang wrote: Hi Max, Could you please review the fixes below for a test bug? Bug: https://bugs.openjdk.java.net/browse/JDK-8143377 Webrev: http://cr.openjdk.java.net/~amjiang/8143377/webrev/ Thanks, Amanda

Re: RFR 8048357: PKCS basic tests

Hi Max, Please check the webrev below which includes fixes for you previous comments: http://cr.openjdk.java.net/~amjiang/8048357/webrev.05/ Thanks, Amanda On 15/11/16 下午11:55, Weijun Wang wrote: Hi Amanda On 11/17/2015 15:03, Amanda Jiang wrote: http://cr.openjdk.java.net/~amjiang

Re: RFR 8048357: PKCS basic tests

/pkcs7/SignerOrder.java:153: Tab character remote: test/sun/security/pkcs/pkcs8/PKCS8Test.java:51: Tab character --Max On Nov 20, 2015, at 1:55 AM, Amanda Jiang <amanda.ji...@oracle.com> wrote: Hi Max, Please check the webrev below which includes fixes for you previous comments

Re: RFR 8048357: PKCS basic tests

eption. - EXPECTED_ALG_ID_CHRS can be just a String with \n and \t inside. pkcs7/*.java: Please take a look at Bernd Eckenfels's comments on Aug 21. I fully agree with him. Thanks Max On Nov 13, 2015, at 4:57 PM, Amanda Jiang <amanda.ji...@oracle.com> wrote: Hi Max, Please che

Re: RFR 8048357: PKCS basic tests

RuntimeException("Length or Original vs read-in " 123 + "should be same"); 124 } PKCS8Test.java: - Typo: s/recieved/received/g Thanks Max On 08/21/2015 07:11 AM, Amanda Jiang wrote: Hi All, Please be free to review new tests for conformance testing

Re: RFR 8050427 LoginContext tests to cover JDK-4703361

map); 59 ptAE[1] = new AppConfigurationEntry("DummyLoginModule", 60 flags[1], 61 map); It seems unnecessary to introduce the flags variable. Thanks Max On 09/22/2015 11:49 PM, Amanda Jiang wrote: Hi Max, Thanks for your comments ,ple

Re: RFR 8050427 LoginContext tests to cover JDK-4703361

words, "isNegative" was for checking if exception is expected. Tests are re-organized , so I do not use these two flags now, please check updated webrev. Thanks Max On 08/17/2015 01:39 PM, Amanda Jiang wrote: Hi All, Please be free to review these new tests for

Re: RFR 8050461: Tests for syntax checking of JAAS configuration file

Thank you Max, Could you please sponsor this ? Thanks, Amanda On 9/21/15, 12:01 AM, Wang Weijun wrote: > Great. Everything looks fine now. > > Thanks > Max > >> 在 2015年9月21日，12:54，Amanda Jiang <amanda.ji...@oracle.com> 写道： >> >> Hi Max, >> >> Th

Re: RFR 8050461: Tests for syntax checking of JAAS configuration file

: Hi Amanda I'd rather see 5 JAAS conf files directly included (instead of generating them with codes). Then it seems you can write a single test with 5 @run lines. Thanks Max On 6/20/2015 6:33 AM, Amanda Jiang wrote: Hello, Please help to review following changeset, which includes new tests

Re: RFR 8050402: Tests to check for use of policy files

/java.security.policy=ExtensiblePolicyTest1.policy ExtensiblePolicyTest1 false @run main/java.security.policy=ExtensiblePolicyTest2.policy ExtensiblePolicyTest1 true etc.. I think this would lead to a more robust test and eliminate some overhead. Thanks, Sean On 07/14/2015 03:15 PM, Amanda Jiang wrote: Hi

RFR 8048357: PKCS basic tests

Hi All, Please be free to review new tests for conformance testing of PKCS. bug: https://bugs.openjdk.java.net/browse/JDK-8048357 webrev: http://cr.openjdk.java.net/~amjiang/8048357/webrev.01/ Thanks, Amanda

RFR 8075020: Additional interop tests for Java as HTTPS client

Hi All, Please help to review following changeset which add some interoperability testing for Https Client Bug: https://bugs.openjdk.java.net/browse/JDK-8075020 webrev: http://cr.openjdk.java.net/~amjiang/8075020/webrev.01/ Thanks, Amanda

Re: RFR 8075020: Additional interop tests for Java as HTTPS client

Please ignore the request. Thanks, Amanda On 8/20/15, 2:47 PM, Amanda Jiang wrote: Hi All, Please help to review following changeset which add some interoperability testing for Https Client Bug: https://bugs.openjdk.java.net/browse/JDK-8075020 webrev: http://cr.openjdk.java.net/~amjiang

RFR 8050427 LoginContext tests to cover JDK-4703361

Hi All, Please be free to review these new tests for Dynamic configuration of authentication modules. Bug: https://bugs.openjdk.java.net/browse/JDK-8050427 webrev:http://cr.openjdk.java.net/~amjiang/8050427/webrev.01/ Thanks, Amanda

RFR 8050402: Tests to check for use of policy files

Hi, Please review a new test which checks Policy is extensible with user defined permissions. Bug: https://bugs.openjdk.java.net/browse/JDK-8050402 Webrev: http://cr.openjdk.java.net/~amjiang/8050402/webrev.01/ Thanks, Amanda

RFR 8050461: Tests for syntax checking of JAAS configuration file

Hello, Please help to review following changeset, which includes new tests to Verify syntax checking of java.security.auth.login.config file. Bug: https://bugs.openjdk.java.net/browse/JDK-8050461 Webrev: http://cr.openjdk.java.net/~amjiang/8050461/webrev.02/ Thanks, Amanda

Re: Please review CR 8050409: Test for JAAS getPrivateCredentials

Max, Thanks for reviewing this, could you please sponsor it? (My JDK author ID is amjiang) Thanks, Amanda On 6/18/15, 2:21 AM, Weijun Wang wrote: Hi Amanda The test looks fine. Thanks Max On 2/26/2015 4:54 AM, Amanda Jiang wrote: Hi All, Could you please review following changeset

Re: Please review CR8048360 Test signed jar files

Hi Max, Thanks for reviewing this changeset, could you please sponsor this? Regards, Amanda On 2/25/15 4:24 PM, Weijun Wang wrote: Looks fine. Thanks Max On 2/26/2015 4:41, Amanda Jiang wrote: Hi All, Could you please review following changeset for 1 new test, which check various

Re: Please review CR8048360 Test signed jar files

:27, Amanda Jiang amanda.ji...@oracle.com wrote: Hi Max, Thanks for reviewing this changeset, could you please sponsor this? Regards, Amanda On 2/25/15 4:24 PM, Weijun Wang wrote: Looks fine. Thanks Max On 2/26/2015 4:41, Amanda Jiang wrote: Hi All, Could you please review following

Please review CR 8050409: Test for JAAS getPrivateCredentials

Hi All, Could you please review following changeset, which includes one new test to test permission checks with Subject.getPrivateCredentials. Bug: https://bugs.openjdk.java.net/browse/JDK-8050409 Webrev:http://cr.openjdk.java.net/~tyan/amandaj/8050409/webrev.02/ Thanks, Amanda

Please review CR8048360 Test signed jar files

Hi All, Could you please review following changeset for 1 new test, which check various combinations of permissions to execute the code from a signed jar file. Bug: https://bugs.openjdk.java.net/browse/JDK-8048360 webrev: http://cr.openjdk.java.net/~tyan/amandaj/8048360/webrev.01/

Re: Please review CR 8049021 Add smartcardio tests with APDU buffer

Hi Valerie, Thanks for reviewing this changeset, could you please sponsor this? Regards, Amanda On 12/29/14 1:51 PM, Valerie Peng wrote: Hi, Amanda, Your changes look fine. Thanks, Valerie On 9/9/2014 5:52 PM, Amanda Jiang wrote: Hello, Please help to review the changeset below, new

Re: Please review CR8048819 Implement reliability test for DH algorithm

, can you please add the SunJCE provider name when calling getInstance()? This would means that you need to update the test to handle NoSuchProviderException, etc. But should be minor changes. Thanks, Valerie On 10/12/2014 5:29 PM, Amanda Jiang wrote: Hello, Please help to review

Please review CR8048819 Implement reliability test for DH algorithm

Hello, Please help to review the changeset below, the new test stressful verifies the assertion of The secret keys generated by all involved parties should be the same for javax.crypto.KeyAgreement. Bug - https://bugs.openjdk.java.net/browse/JDK-8048819 Webrev -

Please review CR 8049021 Add smartcardio tests with APDU buffer

Hello, Please help to review the changeset below, new tests are added for javax.smartcardio.CommandAPDU, javax.smartcardio.ResponseAPDU and javax.smartcardio.TerminalFactorySpi. Bug - https://bugs.openjdk.java.net/browse/JDK-8049021 Webrev -

Re: RFR 8047031: Need new tests to check socket permission

the socket permission instances dynamically accordingly? Or would this make the test very difficult to debug? -Chris. On 25/08/14 17:48, Amanda Jiang wrote: Hi Michael, Chris and others We’re working on moving our internal security tests to open idk repo(Include refactoring effort). Could you

Re: RFR 8047031: Need new tests to check socket permission

Hi Michael, Chris and others We’re working on moving our internal security tests to open idk repo(Include refactoring effort). Could you please help to review these tests? Thanks, Amanda On 7/28/14 5:25 PM, Amanda Jiang wrote: Hi All, Could you please review 1 new test to be added

Re: RFR J8050281: New permission tests for JEP 140

Hi Sean, Thank you for reviewing this. I have improved codes by your suggestions. New webrev link: http://cr.openjdk.java.net/~tyan/amandaj/8050281/webrev.02/ Thanks, Amanda On 8/19/14 10:13 AM, Sean Mullan wrote: On 08/06/2014 06:25 PM, Amanda Jiang wrote: Sorry, wrong webrev link

Re: RFR J8050281: New permission tests for JEP 140

Updated the original codes for better handling interrupted exception. webrev: http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.01/ Thanks, Amanda On 7/30/14 4:50 PM, Amanda Jiang wrote: Hi All, Could you please review following 2 new regression tests to be added for JEP140 (Limied

Re: RFR J8050281: New permission tests for JEP 140

Sorry, wrong webrev link, it should be: http://cr.openjdk.java.net/~tyan/amandaj/8050281/webrev.01/ Thanks, Amanda On 8/6/14 3:24 PM, Amanda Jiang wrote: Updated the original codes for better handling interrupted exception. webrev: http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev

RFR J8050281: New permission tests for JEP 140

Hi All, Could you please review following 2 new regression tests to be added for JEP140 (Limied doPrivileged). New tests are added to perform permission tests for limited doprivileged with multiple threads , and basic API testing. JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8050281