On Tue, 14 Jun 2022 12:18:52 GMT, Matthias Baesken wrote:
>> When trying to construct an LdapURL object with a bad input string (in this
>> example the _ in ad_jbs is causing issues), and not using
>> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we
>> run into the
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Changes to `net` and `http` look good.
-
Marked as reviewed by dfuchs
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Logging/JNDI OK
-
Marked as
On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> d
On Fri, 13 May 2022 11:09:31 GMT, Michael McMahon wrote:
> Question about the code copied in from ThreadInfo. Is there any way we could
> request a change to that class to adjust the number of stack frames printed?
Thanks Michael. I have logged https://bugs.openjdk.java.net/browse/JDK-8286720
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
he test (remove the limit that limited the stack traces
> to 8 element max by no longer relying on `ThreadInfo::toString`)
Daniel Fuchs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merg
On Fri, 6 May 2022 05:16:15 GMT, Jaikiran Pai wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added a comment to ReferenceTracker.java as suggested in the review
>
> src/java.net.h
he test (remove the limit that limited the stack traces
> to 8 element max by no longer relying on `ThreadInfo::toString`)
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Added a comment to ReferenceTracker.java
On Fri, 6 May 2022 04:57:00 GMT, Jaikiran Pai wrote:
>> Hi, please find here a patch that solves a rare intermittent test failure
>> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>>
>> A race condition coupled with some too eager synchronization was causing a
>> deadlock
On Fri, 6 May 2022 04:49:53 GMT, Jaikiran Pai wrote:
>> Hi, please find here a patch that solves a rare intermittent test failure
>> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>>
>> A race condition coupled with some too eager synchronization was causing a
>> deadlock
Hi, please find here a patch that solves a rare intermittent test failure
observed in the test `java/net/httpclient/ExecutorShutdown.java`
A race condition coupled with some too eager synchronization was causing a
deadlock between an Http2Connection close, a thread trying to shutdown the
On Tue, 3 May 2022 02:07:13 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Thu, 28 Apr 2022 07:01:25 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The javax/security/auth/callback/PasswordCallback/CheckCleanerBound.java test
> case failed on one of the test setups. The test runs gc in a loop and
> expects the GC to have
On Thu, 28 Apr 2022 01:34:19 GMT, Joe Darcy wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> out
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in
On Mon, 25 Apr 2022 06:46:20 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java
>> line 105:
>>
>>> 103: private final Set disabledAlgorithms;
>>> 104: private final Constraints algorithmConstraints;
>>> 105: private
On Wed, 20 Apr 2022 15:54:07 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Wed, 20 Apr 2022 15:12:23 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Fri, 15 Apr 2022 15:04:20 GMT, Xue-Lei Andrew Fan wrote:
>> This is an effort to fix a problem introduced in the fix for
>> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
>> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However,
>> there is a
On Fri, 15 Apr 2022 07:20:42 GMT, Xue-Lei Andrew Fan wrote:
>> This is an effort to fix a problem introduced in the fix for
>> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
>> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However,
>> there is a
On Thu, 14 Apr 2022 18:06:10 GMT, Xue-Lei Andrew Fan wrote:
> This is an effort to fix a problem introduced in the fix for
> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However, there
> is a problem
On Thu, 14 Apr 2022 15:53:53 GMT, Xue-Lei Andrew Fan wrote:
>> as of today, this method is never called with a `null` argument
>> (`SSLConfiguration#userSpecifiedAlgorithmConstraints` is initialized to
>> `DEFAULT` and cannot be reset to `null`), but I can add a null check for
>>
On Thu, 14 Apr 2022 04:24:07 GMT, Xue-Lei Andrew Fan wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid nesting SSLAlgorithmConstraints
>
>
On Wed, 13 Apr 2022 19:28:08 GMT, Stuart Marks wrote:
> Reviewers for i18n, net, nio, and security, please review call site changes
> in your areas. Thanks.
Changes to `java.net.http` look good to me. I haven't spotted anything
obviously wrong in the rest, but should defer to reviewers of
On Sat, 9 Apr 2022 06:19:12 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request with a new
On Thu, 7 Apr 2022 04:10:55 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
On Tue, 5 Apr 2022 10:27:54 GMT, Mahendra Chhipa wrote:
> Updated java/net and sun/net/www tests to remove dependency on
> sun.net.www.MessageHeader.
Looks reasonable to me, but please make sure the tests are stable before
pushing. The proxy/tunnel classes have exhibited some instability in
On Sat, 12 Mar 2022 00:55:07 GMT, Bradford Wetmore wrote:
> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal
> internal_error (80) and invalidate existing sessions (either completed or
> under construction) as described in (RFC 4346/TLSv1.1+) if a connection was
>
On Tue, 15 Mar 2022 20:22:16 GMT, Kevin Walls wrote:
> Removing permission checks which, in the presence of a Security Manager,
> would check for a RuntimePermission "className.subclass". This was to
> prevent subclassing these classes, but is no longer necessary with strong
> encapsulation
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote:
> IIRC, localized resource files should have the same copyright year as the
> base English one. That's what I was told by the l10n engineer when I had the
> same comment.
Thanks Naoto! I have no objection then.
-
PR:
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
For simple webserver resource files - should the copyright year be 2022?
-
PR: https://git.openjdk.java.net/jdk/pull/7765
On Mon, 7 Mar 2022 15:11:50 GMT, Сергей Цыпанов wrote:
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()`
On Mon, 7 Mar 2022 07:52:29 GMT, Xue-Lei Andrew Fan wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to javax.net.ssl exceptions. The use of initCause in the JSSE
> implementation code is updated to use the new constructors accordingly.
>
>
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to SocketException and then update uses of initiCause on creating
> SocketException to instead pass the cause via the constructor.
>
> Please also review
On Wed, 16 Feb 2022 21:10:41 GMT, Daniel Fuchs wrote:
> A seemingly innocuous change from
> [JDK-8061729](https://bugs.openjdk.java.net/browse/JDK-8061729) is causing a
> test failure. The fix is to simply revert that small change.
This pull request has been closed without being i
On Wed, 16 Feb 2022 21:49:47 GMT, Daniel Fuchs wrote:
>> A seemingly innocuous change from
>> [JDK-8061729](https://bugs.openjdk.java.net/browse/JDK-8061729) is causing a
>> test failure. The fix is to simply revert that small change.
>
> Daniel Fuchs has updated the
On Thu, 17 Feb 2022 17:13:38 GMT, Mahendra Chhipa wrote:
> Updated TunnelProxy to avoid twice read of Request line.
Looks good to me Mahendra. I will withdraw my own PR. Just make sure to run the
whole of tier2 :-)
-
Marked as reviewed by dfuchs (Reviewer).
PR:
> A seemingly innocuous change from
> [JDK-8061729](https://bugs.openjdk.java.net/browse/JDK-8061729) is causing a
> test failure. The fix is to simply revert that small change.
Daniel Fuchs has updated the pull request with a new target base due to a merge
or a rebase. The increment
A seemingly innocuous change from
[JDK-8061729](https://bugs.openjdk.java.net/browse/JDK-8061729) is causing a
test failure. The fix is to simply revert that small change.
-
Commit messages:
- 8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails
with
On Wed, 16 Feb 2022 21:10:41 GMT, Daniel Fuchs wrote:
> A seemingly innocuous change from
> [JDK-8061729](https://bugs.openjdk.java.net/browse/JDK-8061729) is causing a
> test failure. The fix is to simply revert that small change.
I am currently running tier2 tests
On Wed, 16 Feb 2022 13:55:43 GMT, Mahendra Chhipa wrote:
>> There are some regression tests depending on sun.net.www.MessageHeader, the
>> internal API dependency should be removed. Some of other internal API
>> dependancies are removed in following issues :
>> JDK-8273142
>> JDK-8268464
>>
On Fri, 11 Feb 2022 11:15:56 GMT, Mahendra Chhipa wrote:
>> There are some regression tests depending on sun.net.www.MessageHeader, the
>> internal API dependency should be removed. Some of other internal API
>> dependancies are removed in following issues :
>> JDK-8273142
>> JDK-8268464
>>
On Fri, 28 Jan 2022 16:58:55 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Thu, 27 Jan 2022 18:05:25 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Wed, 26 Jan 2022 19:00:14 GMT, Weijun Wang wrote:
>> test/jdk/sun/security/krb5/auto/HttpsCB.java line 201:
>>
>>> 199: return reader.readLine().equals(CONTENT);
>>> 200: } catch (Exception e) {
>>> 201: return false;
>>
>> Should we log that we have received
On Wed, 26 Jan 2022 16:02:09 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Tue, 25 Jan 2022 10:30:20 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Mon, 24 Jan 2022 13:36:47 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Fri, 21 Jan 2022 16:02:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Fri, 21 Jan 2022 15:26:33 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Fri, 21 Jan 2022 15:26:33 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Fri, 21 Jan 2022 15:08:58 GMT, Michael McMahon wrote:
>> It was being handled elsewhere as "never". But, I agree it would be clearer
>> to normalise it to "never" here.
>
> Sorry, I should have checked back to the source rather than the snippet
> quoted. The problem is that the logError
On Thu, 20 Jan 2022 14:42:56 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 619:
>>
>>> 617: *
>>> 618: * @return a non-null, possibly zero-length array of application
>>> protocol
>>> 619: * {@code String}s. The
On Thu, 20 Jan 2022 07:12:42 GMT, Xue-Lei Andrew Fan wrote:
> In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the
> return statement says that "The array is ordered based on protocol
> preference, with protocols[0] being the most preferred.". However, there is
> no
On Thu, 20 Jan 2022 10:58:27 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Mon, 17 Jan 2022 06:32:13 GMT, Prasadrao Koppula
wrote:
>> This system property should only be used for TLS, and the CBT can be used in
>> both the SPNEGO mechanism and the Kerberos 5 mechanism. Therefore I suggest
>> the name should probably contain "tls" (or maybe "https") and
On Sat, 15 Jan 2022 00:49:05 GMT, Weijun Wang wrote:
>> Argh - you're right I missed the fact that the 3 expressions where included
>> in parenthesis. I read it as
>>
>> ! (s.equals("always")) || ...
>
> Shall we log a message if the value is not one of the 3 forms?
Usually malformed values
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote:
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Changes to `java.util.logging` look fine.
-
PR:
On Fri, 14 Jan 2022 10:03:37 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 180:
>>
>>> 178: static String normalizeCBT(String s) {
>>> 179: if (s == null || ! (s.equals("always") ||
>>> 180: s.equals("never") ||
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote:
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a
On Mon, 6 Dec 2021 21:27:48 GMT, Michael McMahon wrote:
> This updates the testkeys keystore file used by SimpleSSLContext in the test
> tree, in order to add subject alt names for the literal IP addresses
> "127.0.0.1" and "::1". This should allow the self signed certificate in the
>
On Tue, 7 Dec 2021 15:00:33 GMT, Daniel Fuchs wrote:
>> This updates the testkeys keystore file used by SimpleSSLContext in the test
>> tree, in order to add subject alt names for the literal IP addresses
>> "127.0.0.1" and "::1". This sh
On Mon, 6 Dec 2021 21:27:48 GMT, Michael McMahon wrote:
> This updates the testkeys keystore file used by SimpleSSLContext in the test
> tree, in order to add subject alt names for the literal IP addresses
> "127.0.0.1" and "::1". This should allow the self signed certificate in the
>
On Tue, 7 Dec 2021 14:24:41 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/sun/net/www/MimeTable.java line 385:
>>
>>> 383:
>>> 384: protected boolean saveAsProperties(File file) {
>>> 385: try (FileOutputStream os = new FileOutputStream(file)) {
>>
>> This is not
On Wed, 6 Oct 2021 20:37:29 GMT, Andrey Turbanov wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use
On Wed, 6 Oct 2021 20:37:29 GMT, Andrey Turbanov wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use
On Wed, 3 Nov 2021 10:11:31 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a trivial cleanup change that updates classes in the
> `java.net.http` module to use the "blessed modifier order".
>
> The changeset was obtained by running `sh ./bin/bles
Hi,
Please find here a trivial cleanup change that updates classes in the
`java.net.http` module to use the "blessed modifier order".
The changeset was obtained by running `sh ./bin/blessed-modifier-order.sh
src/java.net.http`.
best regards,
-- daniel
-
Commit messages:
-
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote:
> This PR follows up one of the recent PRs, where I used a non-canonical
> modifier order. Since the problem was noticed [^1], why not to address it at
> mass?
>
> As far as I remember, the first mass-canonicalization of modifiers took place
On Fri, 29 Oct 2021 16:17:46 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Tue, 26 Oct 2021 16:24:48 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Tue, 26 Oct 2021 12:52:58 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Thu, 21 Oct 2021 18:21:50 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Wed, 20 Oct 2021 11:52:38 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Tue, 19 Oct 2021 13:28:26 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Tue, 12 Oct 2021 15:43:24 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Tue, 12 Oct 2021 15:43:24 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
On Fri, 15 Oct 2021 12:38:14 GMT, Mahendra Chhipa wrote:
>> There are some regression tests depending on sun.net.www.MessageHeader, the
>> internal API dependency should be removed. Some of other internal API
>> dependancies are removed in following issues :
>> JDK-8273142
>> JDK-8268464
>>
On Fri, 15 Oct 2021 12:38:14 GMT, Mahendra Chhipa wrote:
>> There are some regression tests depending on sun.net.www.MessageHeader, the
>> internal API dependency should be removed. Some of other internal API
>> dependancies are removed in following issues :
>> JDK-8273142
>> JDK-8268464
>>
On Thu, 14 Oct 2021 03:25:07 GMT, Jaikiran Pai wrote:
>> The commit here tries to address an intermittent failure reported in
>> https://bugs.openjdk.java.net/browse/JDK-8254267.
>>
>> The `LogParameters` test case sets the log level to `ALL` for the
>> `java.lang.String.class` and then
On Wed, 13 Oct 2021 22:04:23 GMT, Mahendra Chhipa wrote:
> There are some regression tests depending on sun.net.www.MessageHeader, the
> internal API dependency should be removed. Some of other internal API
> dependancies are removed in following issues :
> JDK-8273142
> JDK-8268464
>
On Wed, 13 Oct 2021 14:22:16 GMT, Jaikiran Pai wrote:
>> The commit here tries to address an intermittent failure reported in
>> https://bugs.openjdk.java.net/browse/JDK-8254267.
>>
>> The `LogParameters` test case sets the log level to `ALL` for the
>> `java.lang.String.class` and then
On Wed, 13 Oct 2021 14:22:16 GMT, Jaikiran Pai wrote:
>> The commit here tries to address an intermittent failure reported in
>> https://bugs.openjdk.java.net/browse/JDK-8254267.
>>
>> The `LogParameters` test case sets the log level to `ALL` for the
>> `java.lang.String.class` and then
On Sat, 2 Oct 2021 20:05:37 GMT, Andrey Turbanov wrote:
> Cleanup unnecessary String.valueOf calls (and similar) when conversion will
> happen implicitly anyway
LGTM
Hi Andrey - I will sponsor this change.
-
Marked as reviewed by dfuchs (Reviewer).
PR:
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov
wrote:
> There are few places in code where manual `for` loop is used with Iterator to
> iterate over Collection.
> Instead of manual `for` cycles it's preferred to use enhanced-for cycle
> instead: it's less verbose, makes code easier to read
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov
wrote:
> There are few places in code where manual `for` loop is used with Iterator to
> iterate over Collection.
> Instead of manual `for` cycles it's preferred to use enhanced-for cycle
> instead: it's less verbose, makes code easier to read
On Tue, 21 Sep 2021 12:26:25 GMT, Pavel Rappo wrote:
> 8274075: Fix miscellaneous typos in java.base
Marked as reviewed by dfuchs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5610
On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote:
> The "java.util.logging.LogManager" class uses the "threadgroup sandboxing"
> via an AppContext to support "applet logging isolation". The AppContext class
> became useless since the plugin and webstart are no longer supported and
>
On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov
wrote:
> There are few places in code where manual while loop is used with Iterator to
> iterate over Collection.
> Instead of manual while cycles it's preferred to use enhanced-for cycle
> instead: it's less verbose, makes code easier to read
On Tue, 24 Aug 2021 20:21:52 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8272863: Replace
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
java/net and sun/net changes LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5229
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote:
>> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120.
>>
>> In many places standard charsets are looked up via their names, for example:
>> absolutePath.getBytes("UTF-8");
>>
>> This could be done more efficiently(up
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote:
> C-style array declarations generate noisy warnings in IDEs, et.c. This patch
> cleans up all java.* packages.
>
> (Copyrights intentionally not updated due the triviality of most changes)
Marked as reviewed by dfuchs (Reviewer).
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
>
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
>
1 - 100 of 294 matches
Mail list logo