On Fri, 15 Apr 2022 15:04:20 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> This is an effort to fix a problem introduced in the fix for >> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which >> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However, >> there is a problem with the code changes. The Runnables registered with >> Cleaner refer to the object being registered ('this'). Meaning, the Cleaner >> mechanism will keep the objects reachable, preventing them from being >> cleaned and collected. > > Xue-Lei Andrew Fan has updated the pull request incrementally with one > additional commit since the last revision: > > more update on replace lambda The latest updates LGTM. I have only looked at the generic Cleaner usage side of things - you will need someone from the security-libs team to have a look at the security-libs implementation logic... ------------- PR: https://git.openjdk.java.net/jdk/pull/8248
