Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-04-08 Thread Valerie Peng
Hi Mike, Thanks much for the comments and info~ I filed JDK-8242332 "Add SHA3 support to SunPKCS11 provider" (https://bugs.openjdk.java.net/browse/JDK-8242332) to track the SHA3 support for PKCS11 provider. I think it's easier/cleaner to handle it separately and makes it more visible. As fo

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-04-06 Thread Valerie Peng
Thanks for the heads up. It should be straightforward to handle/merge. Valerie On 4/6/2020 12:17 AM, Weijun Wang wrote: FYI: I'm about to work on CMS support for RSASSA-PSS and EdDSA, and would like to move all signature-related methods (everyone starting from makeSigAlg) from AlgorithmId.

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-04-06 Thread Weijun Wang
FYI: I'm about to work on CMS support for RSASSA-PSS and EdDSA, and would like to move all signature-related methods (everyone starting from makeSigAlg) from AlgorithmId.java to SingatureUtil.java. Hopefully it will not conflict with your code change. --Max > On Mar 21, 2020, at 5:48 PM, Weiju

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-04-03 Thread Michael StJohns
Hi Valerie - In line On 4/3/2020 5:32 PM, Valerie Peng wrote: Hi Mike, We can update SunPKCS11 provider when the PKCS#11 official header files are updated with SHA3 and Hmac w/ SHA3. I agree with you on the ideal case is to have no lagging in JCA and the SunPKCS11 provider. The main rea

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-04-03 Thread Valerie Peng
Hi Mike, We can update SunPKCS11 provider when the PKCS#11 official header files are updated with SHA3 and Hmac w/ SHA3. I agree with you on the ideal case is to have no lagging in JCA and the SunPKCS11 provider. The main reason for the lagging is that we need to test and make sure the add

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-31 Thread Michael StJohns
Sorry - this one got past me. For PKCS11 - the assignment of mechanism numbers can happen at any time and doesn't necessarily result in a new version of the specification.  In this case, the API won't change, so there's no reason - since the mechanism numbers have been assigned since last May

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-21 Thread Weijun Wang
> On Mar 21, 2020, at 2:39 AM, Valerie Peng wrote: > > As I have started prototyping changes for minimizing the current duplication > of oids in various providers and sun.security.x509.AlgorithmId class, I > choose to leave AlgorithmId class out for now. Very glad to hear this. No need to t

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-20 Thread Valerie Peng
Sure, I will do that. Thanks for the review~ Valerie On 3/19/2020 11:08 PM, Jamil Nimeh wrote: The CSR looks straightforward to me.  You might mention that these algorithms are Standard Names in the specification section, but it's just a nit. --Jamil On 3/19/2020 3:50 PM, Valerie Peng wrote:

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-20 Thread Valerie Peng
I can add a comment to the RFE to make this clear. Regards, Valerie hTH Bernd -- http://bernd.eckenfels.net Von: security-dev im Auftrag von Valerie Peng Gesendet: Wednesday, March 18, 2020 11:57:37 PM An: OpenJDK Dev list Betreff: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Jamil Nimeh
The CSR looks straightforward to me.  You might mention that these algorithms are Standard Names in the specification section, but it's just a nit. --Jamil On 3/19/2020 3:50 PM, Valerie Peng wrote: CSR: https://bugs.openjdk.java.net/browse/JDK-8241325 Please review~ Thanks! Valerie On 3/19

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Weijun Wang
va.net/browse/JDK-8051408). I only added the missing >> OIDs and the supporting classes, i.e. KeyGenerator for Hmac w/ truncated >> SHA512 variants. I can add a comment to the RFE to make this clear. >> >> Regards, >> >> Valerie >> >>> >&

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Valerie Peng
*Betreff:* [15] RFR 8172680: Support SHA-3 based Hmac algorithms Anyone has time to help review this straight forward RFE? It's to add SHA-3 support to Hmac. RFE: https://bugs.openjdk.java.net/browse/JDK-8172680 Webrev: http://cr.openjdk.java.net/~valeriep/8172680/webrev.00/ Mach5 r

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Valerie Peng
CSR: https://bugs.openjdk.java.net/browse/JDK-8241325 Please review~ Thanks! Valerie On 3/19/2020 12:54 PM, Valerie Peng wrote: And CSR also. On 3/19/2020 12:53 PM, Valerie Peng wrote: Hi Sean, Yes, thanks for the reminder. I will file the release note and provider doc issue for this. V

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Valerie Peng
Hi Mike, Thanks for heads up. From what I can gather, SHA3 inclusion is part of PKCS#11 v3. Is this the next release which you are referring to? Or will there be an update to v2.40? Is there any schedule info for these update/release do you know? Following the convention, we normally don't a

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Valerie Peng
d.eckenfels.net *Von:* security-dev im Auftrag von Valerie Peng *Gesendet:* Wednesday, March 18, 2020 11:57:37 PM *An:* OpenJDK Dev list *Betreff:* [15] RFR 8172680: Support SHA-3 based Hmac algorithms Anyone has time to help review this straight forward RFE? It

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Valerie Peng
And CSR also. On 3/19/2020 12:53 PM, Valerie Peng wrote: Hi Sean, Yes, thanks for the reminder. I will file the release note and provider doc issue for this. Valerie On 3/19/2020 8:08 AM, Sean Mullan wrote: Hi Valerie, You should also file a CSR since these would be newly supported algor

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Valerie Peng
Hi Sean, Yes, thanks for the reminder. I will file the release note and provider doc issue for this. Valerie On 3/19/2020 8:08 AM, Sean Mullan wrote: Hi Valerie, You should also file a CSR since these would be newly supported algorithms in the JDK. Please also add a release note and file a

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-19 Thread Sean Mullan
Hi Valerie, You should also file a CSR since these would be newly supported algorithms in the JDK. Please also add a release note and file a docs issue to update the JDK Providers doc with the new algorithms. --Sean On 3/18/20 6:57 PM, Valerie Peng wrote: Anyone has time to help review thi

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-18 Thread Bernd Eckenfels
variants. It's not mentioned in commit message or RFE. hTH Bernd -- http://bernd.eckenfels.net Von: security-dev im Auftrag von Valerie Peng Gesendet: Wednesday, March 18, 2020 11:57:37 PM An: OpenJDK Dev list Betreff: [15] RFR 8172680: Support SHA-3 based

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-18 Thread Michael StJohns
On 3/18/2020 6:57 PM, Valerie Peng wrote: Anyone has time to help review this straight forward RFE? It's to add SHA-3 support to Hmac. RFE: https://bugs.openjdk.java.net/browse/JDK-8172680 Webrev: http://cr.openjdk.java.net/~valeriep/8172680/webrev.00/ Mach5 run is clean. Thanks, Valerie

[15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-18 Thread Valerie Peng
Anyone has time to help review this straight forward RFE? It's to add SHA-3 support to Hmac. RFE: https://bugs.openjdk.java.net/browse/JDK-8172680 Webrev: http://cr.openjdk.java.net/~valeriep/8172680/webrev.00/ Mach5 run is clean. Thanks, Valerie