6995424 Code Review Request

2010-11-19 Thread Sean Mullan
Mandy, Vinnie - Can you review my webrev for 6995424 (Eliminate dependency to a deprecated API com.sun.security.auth.PolicyFile)? http://cr.openjdk.java.net/~mullan/6995424/webrev.00/ Thanks, Sean

Re: 6995424 Code Review Request

2010-11-18 Thread Sean Mullan
Thanks. All suggested code format changes made. --Sean On 11/18/10 12:48 PM, Mandy Chung wrote: On 11/18/10 6:56 AM, Sean Mullan wrote: On 11/17/10 5:18 PM, Mandy Chung wrote: how about "isCustomProvider"? Your comment above describing the flag already explains it's for backward compatibility

Re: 6995424 Code Review Request

2010-11-18 Thread Mandy Chung
On 11/18/10 6:56 AM, Sean Mullan wrote: On 11/17/10 5:18 PM, Mandy Chung wrote: how about "isCustomProvider"? Your comment above describing the flag already explains it's for backward compatibility. I changed it to isCustomPolicy since technically it isn't a Provider. I also added more comm

Re: 6995424 Code Review Request

2010-11-18 Thread Sean Mullan
On 11/17/10 5:18 PM, Mandy Chung wrote: how about "isCustomProvider"? Your comment above describing the flag already explains it's for backward compatibility. I changed it to isCustomPolicy since technically it isn't a Provider. I also added more comments. New webrev: http://cr.openjdk.java

Re: 6995424 Code Review Request

2010-11-17 Thread Mandy Chung
On 11/17/10 12:41 PM, Sean Mullan wrote: On 11/17/2010 02:34 PM, Mandy Chung wrote: Hi Sean, On 11/16/10 5:56 AM, Sean Mullan wrote: http://cr.openjdk.java.net/~mullan/6995424/webrev.00/ Policy.java: I was initially confused with the meaning of 'compatPolicy'. I thought that when 'compatPo

Re: 6995424 Code Review Request

2010-11-17 Thread Sean Mullan
On 11/17/2010 02:34 PM, Mandy Chung wrote: Hi Sean, On 11/16/10 5:56 AM, Sean Mullan wrote: http://cr.openjdk.java.net/~mullan/6995424/webrev.00/ Policy.java: I was initially confused with the meaning of 'compatPolicy'. I thought that when 'compatPolicy' is set to true, it means that the dep

Re: 6995424 Code Review Request

2010-11-17 Thread Mandy Chung
Hi Sean, On 11/16/10 5:56 AM, Sean Mullan wrote: http://cr.openjdk.java.net/~mullan/6995424/webrev.00/ Policy.java: I was initially confused with the meaning of 'compatPolicy'. I thought that when 'compatPolicy' is set to true, it means that the deprecated javax.security.auth.Policy c