Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-19 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.03/ A significant update of CipherBox.java. We are not able to know whether a cipher for a particular key size is available or not until the cipher is successfully initialized. For example, we can get instance for "AES/GCM/NoPadding". Bu

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-19 Thread Bradford Wetmore
EngineOutputRecord.java === 294/296: Another great comment. I might suggest reversing the comments so that the comment about AEAD is in the AEAD arm, and CBC is outside. I'm not sure I catch your ideas. ;-) Would you please show me the code? Just a simple reversal of th

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-18 Thread Xuelei Fan
On 1/19/2013 7:55 AM, Brad Wetmore wrote: > I've pulled out things that need no further discussion. > >> I will be doing a putback of the JCE providers, so I can do your SunJCE >> signed provider putback for you. Let's coordinate when you are ready. >> I will probably be ready early next week. >

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-18 Thread Brad Wetmore
I've pulled out things that need no further discussion. > I will be doing a putback of the JCE providers, so I can do your SunJCE > signed provider putback for you. Let's coordinate when you are ready. > I will probably be ready early next week. I will likely be putting back on Monday, maybe Tu

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-18 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.02/ No significant changes in the new webrev. > I will be doing a putback of the JCE providers, so I can do your SunJCE > signed provider putback for you. Let's coordinate when you are ready. > I will probably be ready early next week.

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2013-01-17 Thread Brad Wetmore
Hi Xuelei, Minor stuff. A couple things to check. Xuelei wrote: Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ JEP 115: http://openjdk.java.net/jeps/115 I looked at webrev.0

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2012-12-28 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.01/ The main update in this webrev is to correct the MAC checking in (Engine)InputRecord to handle null cipher (as TLS_RSA_WITH_NULL_MD5). Thanks, Xuelei On 12/17/2012 10:50 AM, Xuelei Fan wrote: > Ping again ... ;-) > > On 12/4/2012 11

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2012-12-16 Thread Xuelei Fan
Ping again ... ;-) On 12/4/2012 11:07 PM, Xuelei Fan wrote: > Ping ... > > On 11/22/2012 11:00 PM, Xuelei Fan wrote: >> Hi Valerie, Max or Brad, >> >> Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. >> >> webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ >>

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2012-12-04 Thread Xuelei Fan
Ping ... On 11/22/2012 11:00 PM, Xuelei Fan wrote: > Hi Valerie, Max or Brad, > > Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. > > webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ > JEP 115: http://openjdk.java.net/jeps/115 > > In the update, I have n

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2012-11-23 Thread Xuelei Fan
On 11/23/2012 8:01 PM, Florian Weimer wrote: > On 11/23/2012 12:54 PM, Xuelei Fan wrote: >> On 11/23/2012 7:22 PM, Florian Weimer wrote: >>> On 11/22/2012 04:00 PM, Xuelei Fan wrote: Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 1

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2012-11-23 Thread Florian Weimer
On 11/23/2012 12:54 PM, Xuelei Fan wrote: On 11/23/2012 7:22 PM, Florian Weimer wrote: On 11/22/2012 04:00 PM, Xuelei Fan wrote: Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ J

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2012-11-23 Thread Xuelei Fan
On 11/23/2012 7:22 PM, Florian Weimer wrote: > On 11/22/2012 04:00 PM, Xuelei Fan wrote: >> Hi Valerie, Max or Brad, >> >> Can you review the update for JDK-7030966? It is the JSSE part of JEP >> 115. >> >> webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ >> JEP 115: http://openjdk.ja

Re: Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2012-11-23 Thread Florian Weimer
On 11/22/2012 04:00 PM, Xuelei Fan wrote: Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ JEP 115: http://openjdk.java.net/jeps/115 In the update, I have not remove the debug sync

Code Review Request for 7030966, Support AEAD CipherSuites (JSSE part of JEP 115)

2012-11-22 Thread Xuelei Fan
Hi Valerie, Max or Brad, Can you review the update for JDK-7030966? It is the JSSE part of JEP 115. webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/ JEP 115: http://openjdk.java.net/jeps/115 In the update, I have not remove the debug synchronization. I will remove them before push