On 6/7/2018 6:29 PM, Weijun Wang wrote:
Have you updated it yourself?
I did not.
I have a proposal at
http://cr.openjdk.java.net/~weijun/999/webrev.hello-cookie-manager/
Looks fine to me.
Minor nit: Would you mind limit the maximum line character to 80
characters (line 250)?
Th
Have you updated it yourself? I have a proposal at
http://cr.openjdk.java.net/~weijun/999/webrev.hello-cookie-manager/
--Max
> On Jun 6, 2018, at 10:40 PM, Xuelei Fan wrote:
>
> On 6/5/2018 8:48 PM, Weijun Wang wrote:
>>> On 6/5/2018 6:54 AM, Weijun Wang wrote:
HelloCookieManager.j
On 6/5/2018 8:48 PM, Weijun Wang wrote:
On 6/5/2018 6:54 AM, Weijun Wang wrote:
HelloCookieManager.java:
44 HelloCookieManager(SecureRandom secureRandom) {
45 this.secureRandom = secureRandom;
46 }
47
48 HelloCookieManager valueOf(ProtocolVersion protocolVersio
> On 6/5/2018 6:54 AM, Weijun Wang wrote:
>> HelloCookieManager.java:
>> 44 HelloCookieManager(SecureRandom secureRandom) {
>> 45 this.secureRandom = secureRandom;
>> 46 }
>> 47
>> 48 HelloCookieManager valueOf(ProtocolVersion protocolVersion) {
>> Why not just creat
Update: http://hg.openjdk.java.net/jdk/sandbox/rev/ec5537b61038
Note that the above changeset will be included in next webrev for
further code review.
On 6/5/2018 6:54 AM, Weijun Wang wrote:
HelloCookieManager.java:
44 HelloCookieManager(SecureRandom secureRandom) {
45 this
HelloCookieManager.java:
44 HelloCookieManager(SecureRandom secureRandom) {
45 this.secureRandom = secureRandom;
46 }
47
48 HelloCookieManager valueOf(ProtocolVersion protocolVersion) {
Why not just create a static method and make HelloCookieManager abstract?
