HelloCookieManager.java: 44 HelloCookieManager(SecureRandom secureRandom) { 45 this.secureRandom = secureRandom; 46 } 47 48 HelloCookieManager valueOf(ProtocolVersion protocolVersion) { Why not just create a static method and make HelloCookieManager abstract?
static HelloCookieManager of(SecureRandom secureRandom, ProtocolVersion protocolVersion) I haven't seen "raw" HelloCookieManager used anywhere. Also, if createCookie() and isCookieValid() are only called on the server side, why not always use ServerHandshakeContext? Thanks Max > On Jun 5, 2018, at 12:12 PM, Xuelei Fan <xuelei....@oracle.com> wrote: > > > http://cr.openjdk.java.net/~xuelei/8196584/webrev-full.01