Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

On 9/15/2016 9:36 AM, Wang Weijun wrote: I see. But krb5 cipher suites is just a very small part of TLS. Maybe we can tweak the tests a little so that they can work without JGSS. Agreed. I don't like the dependence, too. Let's consider an enhancement later in a separate enhancement. Xuel

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

I see. But krb5 cipher suites is just a very small part of TLS. Maybe we can tweak the tests a little so that they can work without JGSS. I am fine with the change at the moment. Thanks Max > On Sep 15, 2016, at 7:39 AM, Xuelei Fan wrote: > > I did some research yesterday. The "/javax/net/ss

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

I did some research yesterday. The "/javax/net/ssl/TLSCommon" lib depends on krb5. For example, BufferOverflowUnderflowTest need to set up KDC and test krb5 cipher suites. Xuelei On 9/15/2016 6:21 AM, Wang Weijun wrote: Confusing. This does not show why jgss is needed. I'll do some investig

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

Confusing. This does not show why jgss is needed. I'll do some investigation. Thanks Max > 在 2016年9月14日，23:57，Sergei Kovalev 写道： > > java.lang.module.ResolutionException: Module java.naming not found, required > by java.security.jgss

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

here it is an example jtreg -verbose:all -jdk /home/skovalev/TRASH/jdk-9 -javaoptions:"--limit-modules java.base" /home/skovalev/repos/jdk9-dev/jdk/test/javax/net/ssl/TLSv11/TLSHandshakeTest.java STDOUT: Error occurred during initialization of VM java.lang.module.ResolutionException: Module

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

OK. Looks fine to me. Thanks, Xuelei On 9/14/2016 9:58 PM, Sergei Kovalev wrote: Hi Xuelei, I discovered 53 tests in javax/net/ssl folder that refer to /sun/security/krb5/auto. In general it is about 10 unique tests. All the tests depends on KDC class. In other places the tests repeated with

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

14.09.16 16:56, Wang Weijun wrote: I also have no idea why these are needed: + * @modules java.security.jgss + * jdk.security.auth Do the test uses KRB5-related cipher suites? The tests using /sun/security/krb5/auto. Looks like it is the root cause. Thanks Max On Sep 14, 2016, a

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

Hi Xuelei, I discovered 53 tests in javax/net/ssl folder that refer to /sun/security/krb5/auto. In general it is about 10 unique tests. All the tests depends on KDC class. In other places the tests repeated with different set of environment variable. e.g. "-Dtest.security.protocol=TLSv1.1", e

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

I also have no idea why these are needed: + * @modules java.security.jgss + * jdk.security.auth Do the test uses KRB5-related cipher suites? Thanks Max > On Sep 14, 2016, at 8:54 PM, Xuelei Fan wrote: > > Hi Sergei, > > Thanks for the update. The fix looks fine to me. However, I'm

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

Hi Sergei, Thanks for the update. The fix looks fine to me. However, I'm not sure why some tests need the "/sun/security/krb5/auto" libraries and the related modules. As you were already there, would you mind help to test whether the "/sun/security/krb5/auto" library can be removed for some

RFR(M): 8166032: Fix module dependencies for javax.SSL tests

Hello Team, Could you please review below fix for Bug ID: https://bugs.openjdk.java.net/browse/JDK-8166032 Code review: http://cr.openjdk.java.net/~skovalev/8166032/webrev.00/ Issue: The test should be able to pass or skipped by JTreg test suite if required modules have not been included in cu