Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Phil Race
ava.net>; security- d...@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding Hi Goetz, DataBufferNative.c Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer. 75 lockInfo.resBase = NULL; Did you actually compi

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Semyon Sadetsky
that your openJdk name is Vinnie?) -Original Message- From: Vincent Ryan [mailto:vincent.x.r...@oracle.com] Sent: Mittwoch, 30. November 2016 14:53 To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> Cc: awt-...@openjdk.java.net; security-dev@openjdk.java.net Subject: Re: RFR(M): 8170525

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Prasanta Sadhukhan
ap.com> Cc: awt-...@openjdk.java.net; security-dev@openjdk.java.net Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding Hello Goetz, Please modify the bug summary to reference ECC too. Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source code headers will nee

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
(Am I correct that your openJdk name is Vinnie?) > > > > > > > > -Original Message- > > From: Vincent Ryan > > [mailto:vincent.x.r...@oracle.com] > > Sent: Mittwoch, 30.

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
rgey.bylok...@oracle.com>; Lindenmaier, Goetz > <goetz.lindenma...@sap.com>; Vincent Ryan <vincent.x.r...@oracle.com> > Cc: awt-...@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; security- > d...@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] RF

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
et; 2d-dev <2d-...@openjdk.java.net>; security- > d...@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues > in awt coding > > Hi Goetz, > > > DataBufferNative.c > > Using uninitialized value lockInfo.rasBase when calling DBN

RE: RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
Langer, Christoph > Sent: Mittwoch, 30. November 2016 20:47 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> > Cc: awt-...@openjdk.java.net; security-dev@openjdk.java.net; 2d- > d...@openjdk.java.net; Vincent Ryan <vincent.x.r...@oracle.com> > Subject: RE: RFR(M): 817052

RE: RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Lindenmaier, Goetz
.@sap.com> > Cc: awt-...@openjdk.java.net; security-dev@openjdk.java.net > Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding > > Note that I have reviewed only the ECC/PKCS11 changes. > You’ll need a JDK 9 reviewer from awt-dev for your remaining changes. > > There i

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Phil Race
t;goetz.lindenma...@sap.com> Cc: awt-...@openjdk.java.net; security-dev@openjdk.java.net Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding Hello Goetz, Please modify the bug summary to reference ECC too. Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 sourc

RE: RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Langer, Christoph
enmaier, Goetz > Sent: Mittwoch, 30. November 2016 16:41 > To: Vincent Ryan <vincent.x.r...@oracle.com> > Cc: awt-...@openjdk.java.net; security-dev@openjdk.java.net > Subject: RE: RFR(M): 8170525: Fix minor issues in awt coding > > Hi Vincent, > > thanks for the quit rev

Re: RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Sergey Bylokhov
gt; Cc: awt-...@openjdk.java.net; security-dev@openjdk.java.net Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding Hello Goetz, Please modify the bug summary to reference ECC too. Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source code headers will need to be u

RE: RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Lindenmaier, Goetz
ava.net; security-dev@openjdk.java.net > Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding > > Hello Goetz, > > Please modify the bug summary to reference ECC too. > Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source > code headers will need

RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Lindenmaier, Goetz
Hi, I'd like to propose a row of smaller fixes where code is noted down a bit questionable. SAP's quality process requires that we fix these in our internal delivery, and I Would like to share my fixes with openJdk. Some of these fixes are of more theoretical nature as how I understand the code