Sean Mullan
Sent: Wednesday, April 11, 2018 1:42 AM
To: Sibabrata Sahoo <sibabrata.sa...@oracle.com>; Adam Petcher
<adam.petc...@oracle.com>; security-dev@openjdk.java.net
Subject: Re: RFR: 8200219: Develop new tests for using new elliptic curves:
curve25519 and curve448
On 4/9/18 10:
On 4/9/18 10:13 AM, Sibabrata Sahoo wrote:
Here is the new patch addressing all comments.
Webrev:http://cr.openjdk.java.net/~ssahoo/8184359/webrev.01/
Changes includes:
1)
KeyAgreementTest.java
KeySizeTest.java
I have ensured no duplicate Test cases exist for the functionality
t;; security-dev@openjdk.java.net
Subject: Re: RFR: 8200219: Develop new tests for using new elliptic curves:
curve25519 and curve448
A few comments so far; have not finished my review yet.
General comment:
Many of these tests test more than XDH. That is fine and good for increasing
coverage,
Develop new tests for using new elliptic curves:
curve25519 and curve448
A few comments so far; have not finished my review yet.
General comment:
Many of these tests test more than XDH. That is fine and good for increasing
coverage, but have you looked through existing tests to see if you are
A few comments so far; have not finished my review yet.
General comment:
Many of these tests test more than XDH. That is fine and good for
increasing coverage, but have you looked through existing tests to see
if you are duplicating anything we are already testing and maybe those
tests could
I have a couple of minor comments. I am not a Reviewer, so someone else
will still need to look at this.
KeySizeTest: You can use the byteArrayToHexString that is in Convert in
the test lib. See TestXDH.java for an example of how this method is
imported and used.
MultiThreadTest: In
