Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t… [v2]

2020-12-08 Thread Sean Mullan
On Tue, 8 Dec 2020 18:42:22 GMT, Xue-Lei Andrew Fan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated with implSpec tag > > Marked as reviewed by xuelei (Reviewer). This will also require a CSR since you are

Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t…

2020-12-08 Thread Xue-Lei Andrew Fan
On Tue, 8 Dec 2020 17:52:34 GMT, Hai-May Chao wrote: > This is a spec change with noreg-doc label. There is a "Title mismatch between PR and JBS" issue. I think it could be solved by use the same title/subject for the pull request and bug in JBS. - PR: https://git.openjdk.java.ne

Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t… [v2]

2020-12-08 Thread Xue-Lei Andrew Fan
On Tue, 8 Dec 2020 18:36:15 GMT, Hai-May Chao wrote: >> This is a spec change with noreg-doc label. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Updated with implSpec tag Marked as reviewed by xuelei (Reviewer). src/ja

Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t… [v2]

2020-12-08 Thread Hai-May Chao
On Tue, 8 Dec 2020 18:08:38 GMT, Xue-Lei Andrew Fan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated with implSpec tag > > src/java.base/share/classes/java/security/KeyStoreSpi.java line 319: > >> 317:

Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t… [v2]

2020-12-08 Thread Hai-May Chao
> This is a spec change with noreg-doc label. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: Updated with implSpec tag - Changes: - all: https://git.openjdk.java.net/jdk/pull/1701/files - new: https://git.openjdk.ja

Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t…

2020-12-08 Thread Xue-Lei Andrew Fan
On Tue, 8 Dec 2020 17:52:34 GMT, Hai-May Chao wrote: > This is a spec change with noreg-doc label. src/java.base/share/classes/java/security/KeyStoreSpi.java line 319: > 317: * @throwsCertificateException if any of the certificates > included in > 318: * the keystore dat

RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t…

2020-12-08 Thread Hai-May Chao
This is a spec change with noreg-doc label. - Commit messages: - 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch to its behavior Changes: https://git.openjdk.java.net/jdk/pull/1701/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1701&range=00 Issu