On Fri, 4 Jun 2021 01:29:36 GMT, Anthony Scarpino wrote:
>> engine is one time use per encryption/decryption. But 'originalOut' is for
>> overlap detection/protection which may be used multiple times during
>> multi-part encryption/decrypion. For each overlapDetection()/restoreOut()
>> pair, t
On Fri, 4 Jun 2021 00:16:55 GMT, Anthony Scarpino wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 776:
>>
>>> 774: if (dst != null) {
>>> 775: dst.put(block, 0, len);
>>> 776:
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make some
> performance-based decisions.
>
> Thanks
>
> Tony
An
On Thu, 3 Jun 2021 22:30:38 GMT, Valerie Peng wrote:
>> A engine is a one time use, so setting originalOut to null isn't necessary.
>> engineDoFinal() sets engine = null.
>
> engine is one time use per encryption/decryption. But 'originalOut' is for
> overlap detection/protection which may be
On Thu, 3 Jun 2021 22:07:34 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - missed resultLen and undo decrypt heap hasarray check
>> - code review comments
>> - fix
>
> src/java.base/sha
On Thu, 3 Jun 2021 16:04:19 GMT, Anthony Scarpino wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and mak
On Wed, 2 Jun 2021 03:18:49 GMT, Anthony Scarpino wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 942:
>>
>>> 940:
>>> 941: System.arraycopy(out, originalOutOfs, originalOut,
>>> originalOutOfs,
>>> 942: len);
>>
>> Don
On Thu, 3 Jun 2021 16:04:19 GMT, Anthony Scarpino wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and mak
On Thu, 3 Jun 2021 20:45:41 GMT, Anthony Scarpino wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 84:
>>
>>> 82: private static final int MAX_BUF_SIZE = Integer.MAX_VALUE;
>>> 83: // data size when buffer is divided up to aid in intrinsics
>>
On Wed, 2 Jun 2021 20:23:38 GMT, Anthony Scarpino wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 1610:
>>
>>> 1608: // update the input parameters for what was taken
>>> out of 'in'
>>> 1609: inOfs += inUsed;
On Thu, 3 Jun 2021 19:13:00 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - missed resultLen and undo decrypt heap hasarray check
>> - code review comments
>> - fix
>
> src/java.base/sha
On Thu, 3 Jun 2021 16:04:19 GMT, Anthony Scarpino wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and mak
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make some
> performance-based decisions.
>
> Thanks
>
> Tony
An
On Mon, 24 May 2021 20:33:33 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments update
>
> test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java line 673:
>
>> 671:
>>
On Fri, 21 May 2021 01:19:44 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Wed, 2 Jun 2021 03:26:03 GMT, Anthony Scarpino wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 975:
>>
>>> 973: doUpdate(in, inOff, inLen, output, 0);
>>> 974: } catch (ShortBufferException e) {
>>> 975:
On Fri, 21 May 2021 00:03:40 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Wed, 2 Jun 2021 01:53:51 GMT, Anthony Scarpino wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 741:
>>
>>> 739: } else {
>>> 740: // If the remaining in buffer + data does
>>> not fill a
>>> 741
On Fri, 21 May 2021 00:05:17 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 22:59:18 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 23:27:51 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 20:00:07 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 19:46:51 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 19:06:31 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 18:38:35 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 18:05:48 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 01:17:14 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Thu, 20 May 2021 00:37:44 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Tue, 1 Jun 2021 19:28:44 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 874:
>>
>>> 872: } else if (!src.isDirect() && !dst.isDirect()) {
>>> 873: // if src is read only, then we need a copy
>>> 874:
On Wed, 19 May 2021 23:59:36 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Wed, 19 May 2021 23:10:07 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Wed, 19 May 2021 22:05:16 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Tue, 1 Jun 2021 18:54:19 GMT, Valerie Peng wrote:
>> Yeah, I changed this code long ago, i suspect I didn't realize
>> engineGetParameters() used it
>
> It seems that you still have not saved the specified 'random' into the
> instance 'random' field? Did I miss something?
yeah.. i think i g
On Tue, 1 Jun 2021 16:34:44 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove GCTR reset() calls because GCTR is released after the operation
>> some variable name consistency
>> othe
On Mon, 24 May 2021 22:36:49 GMT, Anthony Scarpino
wrote:
>> test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMShortBuffer.java line 34:
>>
>>> 32: /*
>>> 33: * @test
>>> 34: * @summary Call decrypt doFinal() with different output values to see
>>> if the
>>
>> Missing bug id?
>
> Here is my
On Thu, 20 May 2021 00:57:42 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Fri, 21 May 2021 04:15:44 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 628:
>>
>>> 626: }
>>> 627:
>>> 628: int mergeBlock(byte[] buffer, int bufOfs, byte[] in, int inOfs,
>>
>> Can be made 'static'? No
On Fri, 21 May 2021 03:07:15 GMT, Anthony Scarpino
wrote:
>> yeah these checks are a bit all over the place.. I'll rework them
>
> So I think I only need to add a check to the engineDoFinal() that did not
> have a check before.
for engineUpdate(...) impl, the ArrayUtil.nullAndBoundsCheck() cal
On Mon, 24 May 2021 16:37:05 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 189:
>>
>>> 187: ct.position(ct.position());
>>> 188: return processed;
>>> 189: } else if (!ct.isReadOnly()) {
>>
>> Maybe you meant
On Wed, 26 May 2021 21:13:56 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and m
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make some
> performance-based decisions.
>
> Thanks
>
> Tony
An
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make some
> performance-based decisions.
>
> Thanks
>
> Tony
An
On Mon, 24 May 2021 20:09:06 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments update
>
> test/jdk/com/sun/crypto/provider/Cipher/AES/TestAESCipher.java line 90:
>
>> 88:
On Mon, 24 May 2021 20:38:29 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments update
>
> test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMShortBuffer.java line 34:
>
>> 32: /*
>
On Fri, 21 May 2021 21:18:34 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and m
On Mon, 24 May 2021 18:15:17 GMT, Valerie Peng wrote:
>> src.array() throws an exception if it's read only
>
> Other files seem to use src.hasArray() call which also checked for read only.
> Maybe that's what you meant to use?
Yes, I could use hasArray(). I hadn't started using that until late
On Fri, 21 May 2021 04:07:05 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 640:
>>
>>> 638: * @return number of bytes used from 'in'
>>> 639: */
>>> 640: int mergeBlock(byte[] buffer, int bufOfs, int
On Mon, 24 May 2021 16:54:39 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 338:
>>
>>> 336: public int doFinal(ByteBuffer src, ByteBuffer dst) {
>>> 337: return doFinal(src, src.remaining());
>>> 338: }
>>
>> Have you consid
On Mon, 24 May 2021 16:34:51 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 203:
>>
>>> 201: // allocating and copying for direct bytebuffers
>>> 202: if (!src.isDirect() && !dst.isDirect() &&
>>> 203: !src.isReadOn
On Tue, 18 May 2021 18:38:40 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 338:
>
>> 336: public int doFi
On Mon, 17 May 2021 22:42:40 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review comment updates
>> - Fixed the lack of overlap detection with GCMEncrypt.update()
>
> src/java.base/share
On Tue, 18 May 2021 17:24:13 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 189:
>
>> 187: ct.posi
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make some
> performance-based decisions.
>
> Thanks
>
> Tony
An
On Fri, 21 May 2021 02:03:56 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Fri, 21 May 2021 01:58:43 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Fri, 21 May 2021 01:57:08 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Wed, 19 May 2021 21:18:15 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Wed, 19 May 2021 21:18:27 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Fri, 21 May 2021 02:51:05 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 402:
>>
>>> 400: }
>>> 401: try {
>>> 402: ArrayUtil.nullAndBoundsCheck(input, inputOffset, inputLen);
>>
>> Why is only
On Wed, 19 May 2021 20:21:23 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and m
On Mon, 17 May 2021 21:58:48 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review comment updates
>> - Fixed the lack of overlap detection with GCMEncrypt.update()
>
> src/java.base/share
On Wed, 19 May 2021 19:20:20 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 402:
>
>> 400:
On Tue, 18 May 2021 22:23:11 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 225:
>
>> 223:
On Tue, 18 May 2021 22:46:58 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 168:
>
>> 166:
On Tue, 18 May 2021 21:58:24 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 149:
>
>> 147:
On Tue, 18 May 2021 20:33:22 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 133:
>
>> 131:
On Tue, 18 May 2021 18:52:06 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 75:
>
>> 73: pr
On Tue, 18 May 2021 21:56:38 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounte
On Wed, 19 May 2021 18:17:27 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 259:
>
>> 257:
On Wed, 19 May 2021 18:15:26 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 279:
>
>> 277:
On Wed, 19 May 2021 20:21:23 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and m
On Tue, 18 May 2021 03:18:18 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and m
On Mon, 17 May 2021 21:41:37 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and m
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make some
> performance-based decisions.
>
> Thanks
>
> Tony
An
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make some
> performance-based decisions.
>
> Thanks
>
> Tony
An
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make some
> performance-based decisions.
>
> Thanks
>
> Tony
An
On Mon, 17 May 2021 19:28:04 GMT, Valerie Peng wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and make s
On Mon, 17 May 2021 20:29:37 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 155:
>>
>>> 153: super(32, new AESCrypt());
>>> 154: }
>>> 155: }
>>
>> These should be removed since SunJCE registers
>> com.sun.crypto.prov
On Mon, 17 May 2021 20:24:51 GMT, Valerie Peng wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and make s
On Mon, 17 May 2021 18:13:46 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make s
On Mon, 17 May 2021 18:13:46 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use
> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
> also a major code redesign limits the amount of data copies and make s
Hi,
I need a review of this rather large change to GCM. GCM will no longer use
CipherCore, and AESCrypt to handle it's buffers and other objects. It is also
a major code redesign limits the amount of data copies and make some
performance-based decisions.
Thanks
Tony
-
Commit
82 matches
Mail list logo
