Re: RFR: 8264681: Use the blessed modifier order in java.security [v2]

2021-04-13 Thread Aleksey Shipilev
On Mon, 12 Apr 2021 09:32:13 GMT, Alex Blewitt wrote: >> 8264681: Use the blessed modifier order in java.security > > Alex Blewitt has updated the pull request incrementally with one additional > commit since the last revision: > > Removed upstream licensed code from commit I think all conv

Re: RFR: 8264681: Use the blessed modifier order in java.security [v2]

2021-04-13 Thread Alex Blewitt
On Mon, 12 Apr 2021 09:32:13 GMT, Alex Blewitt wrote: >> 8264681: Use the blessed modifier order in java.security > > Alex Blewitt has updated the pull request incrementally with one additional > commit since the last revision: > > Removed upstream licensed code from commit What happens to

Re: RFR: 8264681: Use the blessed modifier order in java.security [v2]

2021-04-12 Thread Sean Mullan
On Mon, 12 Apr 2021 10:12:06 GMT, Alex Blewitt wrote: > Did a search of the files included in the commit, didn't see anything other > than the two above without the standard Oracle copyright . > > Wasn't sure about > `src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_ATTRIB

Re: RFR: 8264681: Use the blessed modifier order in java.security [v2]

2021-04-12 Thread Alex Blewitt
On Mon, 12 Apr 2021 09:32:13 GMT, Alex Blewitt wrote: >> 8264681: Use the blessed modifier order in java.security > > Alex Blewitt has updated the pull request incrementally with one additional > commit since the last revision: > > Removed upstream licensed code from commit Did a search of

Re: RFR: 8264681: Use the blessed modifier order in java.security [v2]

2021-04-12 Thread Alex Blewitt
> 8264681: Use the blessed modifier order in java.security Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision: Removed upstream licensed code from commit - Changes: - all: https://git.openjdk.java.net/jdk/pull/3338/files

Re: RFR: 8264681: Use the blessed modifier order in java.security

2021-04-12 Thread Alex Blewitt
On Sat, 3 Apr 2021 22:09:55 GMT, Alex Blewitt wrote: > 8264681: Use the blessed modifier order in java.security Sorry, thought those changes had been removed. Let me fix. - PR: https://git.openjdk.java.net/jdk/pull/3338

Re: RFR: 8264681: Use the blessed modifier order in java.security

2021-04-11 Thread Aleksey Shipilev
On Thu, 8 Apr 2021 17:02:20 GMT, Sean Mullan wrote: >> 8264681: Use the blessed modifier order in java.security > > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java > line 390: > >> 388: } >> 389: >> 390: public abstract PSSParameterSpec g

Re: RFR: 8264681: Use the blessed modifier order in java.security

2021-04-11 Thread Aleksey Shipilev
On Sat, 3 Apr 2021 22:09:55 GMT, Alex Blewitt wrote: > 8264681: Use the blessed modifier order in java.security I think some review comments from Sean were left unaddressed... - Changes requested by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3338

Re: RFR: 8264681: Use the blessed modifier order in java.security

2021-04-08 Thread Sean Mullan
On Sat, 3 Apr 2021 22:09:55 GMT, Alex Blewitt wrote: > 8264681: Use the blessed modifier order in java.security The rest looks fine, but I would double-check all the copyrights to see if you are modifying any other 3rd-party code than the ones I commented on. Best to leave that code as-is and

RFR: 8264681: Use the blessed modifier order in java.security

2021-04-03 Thread Alex Blewitt
8264681: Use the blessed modifier order in java.security - Commit messages: - 8264681: Use the blessed modifier order in java.security Changes: https://git.openjdk.java.net/jdk/pull/3338/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3338&range=00 Issue: https://bugs