Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v7]

2021-05-04 Thread Alan Bateman
On Tue, 4 May 2021 12:01:44 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessChecker.java >> line 34: >> >>> 32: import java.util.Set; >>> 33: >>> 34: public final class IllegalNativeAccessChecker { >> >> Are you sure about the name of the

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v7]

2021-05-04 Thread Maurizio Cimadamore
On Tue, 4 May 2021 08:12:23 GMT, Alan Bateman wrote: >> Maurizio Cimadamore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert bad change in benchmark copyright >> - Do not apply optimized bound check if accessed offset/length do

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v7]

2021-05-04 Thread Maurizio Cimadamore
On Tue, 4 May 2021 08:20:43 GMT, Alan Bateman wrote: > Just to double, there is no way to enable native access for modules in module > layers (other than the boot layer), right? No, at the moment it is not possible to enable native access programmatically. We will explore something along those

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v7]

2021-05-04 Thread Alan Bateman
On Fri, 30 Apr 2021 15:20:42 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-412 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v7]

2021-04-30 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/412 Maurizio Cimadamore has updated the pull request