On Mon, 26 Jul 2021 17:03:11 GMT, Sean Mullan wrote:
>> Please review this fix to change the internal `X509CertImpl.getFingerprint`
>> method to not return "" as a fingerprint if there is an error generating
>> that fingerprint. Instead, `null` is now returned, and "" is no longer
>> cached as
On Mon, 26 Jul 2021 14:12:48 GMT, Weijun Wang wrote:
>> Not sure what you mean by inline. Do you mean use an anonymous inner class
>> instead of a lambda for the `Function` argument to
>> `ConcurrentHashMap.computeIfAbsent`? Note that `getFingerprintInternal`
>> calls `this.getEncodedInternal`
> Please review this fix to change the internal `X509CertImpl.getFingerprint`
> method to not return "" as a fingerprint if there is an error generating that
> fingerprint. Instead, `null` is now returned, and "" is no longer cached as a
> valid fingerprint. Although errors generating fingerprin
On Mon, 26 Jul 2021 13:37:39 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 1924:
>>
>>> 1922: x -> getFingerprintInternal(x, debug));
>>> 1923: }
>>> 1924:
>>
>> I'm a little confused by these methods. Can you inline
>> `getFin
On Fri, 23 Jul 2021 22:18:26 GMT, Weijun Wang wrote:
>> Please review this fix to change the internal `X509CertImpl.getFingerprint`
>> method to not return "" as a fingerprint if there is an error generating
>> that fingerprint. Instead, `null` is now returned, and "" is no longer
>> cached as
On Fri, 23 Jul 2021 17:16:26 GMT, Sean Mullan wrote:
> Please review this fix to change the internal `X509CertImpl.getFingerprint`
> method to not return "" as a fingerprint if there is an error generating that
> fingerprint. Instead, `null` is now returned, and "" is no longer cached as a
> v
Please review this fix to change the internal `X509CertImpl.getFingerprint`
method to not return "" as a fingerprint if there is an error generating that
fingerprint. Instead, `null` is now returned, and "" is no longer cached as a
valid fingerprint. Although errors generating fingerprints shoul
