Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-14 Thread zzambers
On Sat, 12 Mar 2022 01:43:16 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Your changes look good to me. When it comes to wording, >> I'll let that to native english speaker(s) to judge :) (As I am not native >> english speaker myself). I built docs locally and result looks good (also >>

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-11 Thread Bradford Wetmore
On Tue, 8 Mar 2022 15:23:13 GMT, zzambers wrote: >>> Sure if more changes are desired I can pull your changes. When It comes to >>> CSR I am not fully familiar with the >> process. Is action expected from my side? >> >> One of us needs to get the CSR approved. Why don't you pull the changes

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]

2022-03-09 Thread Xue-Lei Andrew Fan
On Tue, 8 Mar 2022 15:03:57 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]

2022-03-08 Thread Bradford Wetmore
On Tue, 8 Mar 2022 15:03:57 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-08 Thread Bradford Wetmore
On Tue, 8 Mar 2022 15:23:13 GMT, zzambers wrote: >>> Sure if more changes are desired I can pull your changes. When It comes to >>> CSR I am not fully familiar with the >> process. Is action expected from my side? >> >> One of us needs to get the CSR approved. Why don't you pull the changes

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-08 Thread zzambers
On Mon, 7 Mar 2022 21:01:12 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Sure if more changes are desired I can pull your changes. >> When It comes to CSR I am not fully familiar with the process. Is action >> expected from my side? > >> Sure if more changes are desired I can pull your

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v3]

2022-03-08 Thread zzambers
On Tue, 8 Mar 2022 14:21:19 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]

2022-03-08 Thread zzambers
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-08 Thread zzambers
On Mon, 7 Mar 2022 21:01:12 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Sure if more changes are desired I can pull your changes. >> When It comes to CSR I am not fully familiar with the process. Is action >> expected from my side? > >> Sure if more changes are desired I can pull your

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v3]

2022-03-08 Thread zzambers
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-07 Thread Bradford Wetmore
On Mon, 7 Mar 2022 16:34:08 GMT, zzambers wrote: > Sure if more changes are desired I can pull your changes. When It comes to > CSR I am not fully familiar with the process. Is action expected from my side? One of us needs to get the CSR approved. Why don't you pull the changes described

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-07 Thread zzambers
On Fri, 4 Mar 2022 23:43:30 GMT, Bradford Wetmore wrote: >> zzambers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated copyright for SSLSocket.java > > There are more changes needed, and should probably be done as part of this >

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-04 Thread Bradford Wetmore
On Thu, 3 Mar 2022 12:36:33 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-03 Thread zzambers
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-03 Thread Julian Waters
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-02 Thread Bradford Wetmore
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-02 Thread Bradford Wetmore
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-02 Thread Xue-Lei Andrew Fan
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-02 Thread zzambers
On Wed, 2 Mar 2022 07:13:36 GMT, TheShermanTanker wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >>

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-02 Thread TheShermanTanker
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed

RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-02 Thread zzambers
Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / Socket.shutdownOutput() and InputStream.close() / OutputStream.close() performed half-close of TLS-1.3 connection. However this behaviour has