Re: RFR:8246330:Add TLS Tests for Legacy ECDSA curves

2020-06-08 Thread Rajan Halade
Looks good to me. Thanks, Rajan > On Jun 8, 2020, at 4:34 AM, [email protected] wrote: > > Thanks Rajan. I changed the webrev and ran Mach5 too. Here is the new webrev > link: - > > http://cr.openjdk.java.net/~sshivang/reviews/8246330/webrev.01/ >

Re: RFR:8246330:Add TLS Tests for Legacy ECDSA curves

2020-06-08 Thread shivangi . g . gupta
Thanks Rajan. I changed the webrev and ran Mach5 too. Here is the new webrev link: - http://cr.openjdk.java.net/~sshivang/reviews/8246330/webrev.01/ Thanks Shivangi On 06/06/20 7:37 am, Rajan Halade wrote: One minor comment - Can you please put try-catch around "(new DisabledCurve()).run

Re: RFR:8246330:Add TLS Tests for Legacy ECDSA curves

2020-06-05 Thread Rajan Halade
One minor comment - Can you please put try-catch around "(new DisabledCurve()).run();” instead of over for loop? Otherwise test looks good. Thanks, Rajan > On Jun 4, 2020, at 8:41 PM, [email protected] wrote: > > Corrected the links. > > On 04/06/20 10:59 pm, shivangi.g.gu...@oracl

Re: RFR:8246330:Add TLS Tests for Legacy ECDSA curves

2020-06-04 Thread shivangi . g . gupta
Corrected the links. On 04/06/20 10:59 pm, [email protected] wrote: Hi, May I please find a sponsor for this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8246330 Description:Many of EC named curves has been disabled with security property "jdk.disabled.namedCurves". The pu

RFR:8246330:Add TLS Tests for Legacy ECDSA curves

2020-06-04 Thread shivangi . g . gupta
Hi, May I please find a sponsor for this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8246330 Description:Many of EC named curves has been disabled with security property "jdk.disabled.namedCurves". The purpose of this Test is to verify the behavior of any EC named curve from the disa