> On May 5, 2020, at 6:16 AM, Sean Mullan wrote:
>
> On 5/2/20 2:19 PM, Hai-May Chao wrote:
>>> Looks good otherwise. Please add a release-note and open a follow-on issue
>>> to update the man page with the new option.
>> Done (Release note: JDK-8244285, and man page: JDK-8244274).
>
> I
On 5/2/20 2:19 PM, Hai-May Chao wrote:
Looks good otherwise. Please add a release-note and open a follow-on issue to
update the man page with the new option.
Done (Release note: JDK-8244285, and man page: JDK-8244274).
I added a few more details to the release note. Otherwise, looks good,
> On May 4, 2020, at 10:23 PM, Weijun Wang wrote:
>
>
>
>> On May 5, 2020, at 12:36 PM, Hai-May Chao wrote:
>>
>>
>>
>>> On May 4, 2020, at 6:01 PM, Weijun Wang wrote:
>>>
>>>
>>>
On May 5, 2020, at 3:48 AM, Hai-May Chao wrote:
Hi Max,
> On May 2, 2020, at
> On May 5, 2020, at 12:36 PM, Hai-May Chao wrote:
>
>
>
>> On May 4, 2020, at 6:01 PM, Weijun Wang wrote:
>>
>>
>>
>>> On May 5, 2020, at 3:48 AM, Hai-May Chao wrote:
>>>
>>> Hi Max,
>>>
On May 2, 2020, at 5:25 PM, Weijun Wang wrote:
In jarsigner/Main, you can just
> On May 4, 2020, at 6:01 PM, Weijun Wang wrote:
>
>
>
>> On May 5, 2020, at 3:48 AM, Hai-May Chao wrote:
>>
>> Hi Max,
>>
>>> On May 2, 2020, at 5:25 PM, Weijun Wang wrote:
>>>
>>> In jarsigner/Main, you can just call
>>>
>>> pkixParameters.setRevocationEnabled(revocationCheck);
>>
> On May 5, 2020, at 3:48 AM, Hai-May Chao wrote:
>
> Hi Max,
>
>> On May 2, 2020, at 5:25 PM, Weijun Wang wrote:
>>
>> In jarsigner/Main, you can just call
>>
>> pkixParameters.setRevocationEnabled(revocationCheck);
>
> Ok
>
>>
>> Last time, you mentioned that
Hi Max,
> On May 2, 2020, at 5:25 PM, Weijun Wang wrote:
>
> In jarsigner/Main, you can just call
>
> pkixParameters.setRevocationEnabled(revocationCheck);
Ok
>
> Last time, you mentioned that "Event.clearReportListener()" cannot be called
> immediately after validation check because of
In jarsigner/Main, you can just call
pkixParameters.setRevocationEnabled(revocationCheck);
Last time, you mentioned that "Event.clearReportListener()" cannot be called
immediately after validation check because of some race conditions. Is that
easily reproducible? I still find it strange.
Thanks Max!
Using localhost would do it as well.
Hai-May
> On May 1, 2020, at 7:49 PM, Weijun Wang wrote:
>
>>
>> * EnableRevocation.java
>>
>> - How long does this test take - does it hang for a little while trying to
>> make a connection or timeout right away? If it takes a while, you
Hi Sean,
Thanks for your review. Reply inline.
> On May 1, 2020, at 11:50 AM, Sean Mullan wrote:
>
> * Main.java:
>
> 2067 Event.setReportListener(new Event.Reporter() {
> 2068 @Override
> 2069 public void
>
> * EnableRevocation.java
>
> - How long does this test take - does it hang for a little while trying to
> make a connection or timeout right away? If it takes a while, you could
> experiment with overriding the default timeouts for CRLs and OCSP checks to
> make this test finish faster.
* Main.java:
2067 Event.setReportListener(new Event.Reporter() {
2068 @Override
2069 public void handle(String t, Object... o) {
2070
System.out.println(String.format(rb.getString(t), o));
2071
Hi,
With small change added to ‘Usages.java' test, here is the updated webrev:
https://cr.openjdk.java.net/~hchao/8242060/webrev.01/
Thanks,
Hai-May
> On Apr 30, 2020, at 4:29 PM, Hai-May Chao wrote:
>
> Hi,
>
> I’d like to request a review for:
>
> JBS:
Hi,
I’d like to request a review for:
JBS: https://bugs.openjdk.java.net/browse/JDK-8242060
CSR: https://bugs.openjdk.java.net/browse/JDK-8244046
Webrev: https://cr.openjdk.java.net/~hchao/8242060/webrev.00/
The jarsigner command currently does certificate chain validation, but does not
check
14 matches
Mail list logo
