Thanks. All suggestions accepted. Will push after updated.
--Max
On 01/20/2017 08:01 PM, Artem Smotrakov wrote:
It might be better to remove the response file in a finally block.
Main.java needs new copyright year.
Otherwise, looks fine.
I see you removed public sign() and verify() methods in
It might be better to remove the response file in a finally block.
Main.java needs new copyright year.
Otherwise, looks fine.
I see you removed public sign() and verify() methods in SecurityTools,
please make sure that they are not used by other tests.
Artem
On 01/20/2017 02:44 PM, Weijun
Updated
http://cr.openjdk.java.net/~weijun/8172975/root/webrev.01/
http://cr.openjdk.java.net/~weijun/8172975/webrev.01/
I'll need this in my other work.
Thanks
Max
On 01/20/2017 07:23 PM, Artem Smotrakov wrote:
It's up to you. You can change it now if you have time, or we can do it
once we n
It's up to you. You can change it now if you have time, or we can do it
once we need to update jarsigner tests.
Artem
On 01/20/2017 12:23 PM, Weijun Wang wrote:
Also, I am feeling that the jarsigner-related calls are quite
complicated. I suggest we use the same method for signing and
verifyin
On 01/20/2017 05:01 PM, Artem Smotrakov wrote:
Hi Max,
Please see inline.
On 01/19/2017 05:15 PM, Weijun Wang wrote:
On 01/19/2017 09:40 PM, Artem Smotrakov wrote:
Hi Max,
In general, looks okay.
Would it be better if it called redirectInput() only if the response
file exists? keytool(
Hi Max,
Please see inline.
On 01/19/2017 05:15 PM, Weijun Wang wrote:
On 01/19/2017 09:40 PM, Artem Smotrakov wrote:
Hi Max,
In general, looks okay.
Would it be better if it called redirectInput() only if the response
file exists? keytool() method might also delete the response file after
On 01/19/2017 09:40 PM, Artem Smotrakov wrote:
Hi Max,
In general, looks okay.
Would it be better if it called redirectInput() only if the response
file exists? keytool() method might also delete the response file after
reading it. These two measures may prevent situations when the response
f
Hi Max,
In general, looks okay.
Would it be better if it called redirectInput() only if the response
file exists? keytool() method might also delete the response file after
reading it. These two measures may prevent situations when the response
file is unnecessary used.
What do you think?
Please review the code changes at
root: http://cr.openjdk.java.net/~weijun/8172975/root/webrev.00/
jdk: http://cr.openjdk.java.net/~weijun/8172975/webrev.00/
The fix is in root repo. This is not an elegant solution because it uses
a separate method to provide the response. This means you
