Ok, here's a test...
with just the following change:
diff -r 9ea9fb3c0c88 src/java.base/share/classes/java/math/BigInteger.java
--- a/src/java.base/share/classes/java/math/BigInteger.java Wed Mar
23 18:24:35 2016 +0100
+++ b/src/java.base/share/classes/java/math/BigInteger.java Wed Mar
Hi Xuelei,
On 03/23/2016 04:26 AM, Xuelei Fan wrote:
Hi,
Please review the update for the supporting of BigInteger.TWO:
http://cr.openjdk.java.net/~xuelei/8152237/webrev/
BigInteger.valueOf(2) is a common BigInteger value used in binary and
cryptography operation calculation. The BigInte
Sorry for beating the dead horse of ObjectIdentifier.java change, but I’d
suggest that if that code is later revisited, it be changed to
"first.compareTo(BigInteger.TWO) > 0" instead of “… == 1”.
Comparing the return value of compareTo to zero (instead of relying on specific
set of return value
Thanks!
Xuelei
On 3/23/2016 9:44 PM, Wang Weijun wrote:
>
>> On Mar 23, 2016, at 7:23 PM, Xuelei Fan wrote:
>>
>> On 3/23/2016 5:44 PM, Wang Weijun wrote:
>>> Then why not fix the 2 bugs in a single changeset?
>>>
>> Both need spec update approval. As they are completely different spec
>> upda
> On Mar 23, 2016, at 7:23 PM, Xuelei Fan wrote:
>
> On 3/23/2016 5:44 PM, Wang Weijun wrote:
>> Then why not fix the 2 bugs in a single changeset?
>>
> Both need spec update approval. As they are completely different spec
> update, better to update in 2 enhancements.
>
> As you have concerns
Hi Attila,
Good catch about the comparing. I updated the code in my local
workspace, and I would ask for code review in another enhancement update
soon.
Thanks,
Xuelei
On 3/23/2016 9:15 PM, Attila Szegedi wrote:
> Sorry for beating the dead horse of ObjectIdentifier.java change, but
> I’d sugge
On 3/23/2016 5:44 PM, Wang Weijun wrote:
> Then why not fix the 2 bugs in a single changeset?
>
Both need spec update approval. As they are completely different spec
update, better to update in 2 enhancements.
As you have concerns here, I removed ObjectIdentifier.java from this
update. See the
Then why not fix the 2 bugs in a single changeset?
--Max
> 在 2016年3月23日，17:06，Xuelei Fan 写道：
>
>> On 3/23/2016 3:34 PM, Wang Weijun wrote:
>>
>>> On Mar 23, 2016, at 12:48 PM, Xuelei Fan wrote:
>>>
>>> On 3/23/2016 12:10 PM, Wang Weijun wrote:
Only 3 files touched. Are you going to make
On 3/23/2016 3:34 PM, Wang Weijun wrote:
>
>> On Mar 23, 2016, at 12:48 PM, Xuelei Fan wrote:
>>
>> On 3/23/2016 12:10 PM, Wang Weijun wrote:
>>> Only 3 files touched. Are you going to make the
>>> s/BigInteger.valueOf(2)/BigInteger.TWO/ changes in other files with another
>>> bug fix?
>>>
>> T
> On Mar 23, 2016, at 12:48 PM, Xuelei Fan wrote:
>
> On 3/23/2016 12:10 PM, Wang Weijun wrote:
>> Only 3 files touched. Are you going to make the
>> s/BigInteger.valueOf(2)/BigInteger.TWO/ changes in other files with another
>> bug fix?
>>
> There are also uses in security components. I wil
On 3/23/2016 12:10 PM, Wang Weijun wrote:
Only 3 files touched. Are you going to make the
s/BigInteger.valueOf(2)/BigInteger.TWO/ changes in other files with another bug
fix?
There are also uses in security components. I will make the update in
another bug.
Thanks,
Xuelei
Thanks
Max
On
Only 3 files touched. Are you going to make the
s/BigInteger.valueOf(2)/BigInteger.TWO/ changes in other files with another bug
fix?
Thanks
Max
> On Mar 23, 2016, at 11:26 AM, Xuelei Fan wrote:
>
> Hi,
>
> Please review the update for the supporting of BigInteger.TWO:
>
> http://cr.openjd
12 matches
Mail list logo
