Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-29 Thread Sean Mullan
On 11/28/17 2:41 PM, mandy chung wrote: On 11/22/17 6:37 AM, Sean Mullan wrote: Please review this change to remove the pre-JDK 1.2 SecurityManager methods that have been deprecated since JDK 1.2 and marked for removal in JDK 9. These methods are fragile, error-prone and have been obsolete s

Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-28 Thread mandy chung
On 11/22/17 6:37 AM, Sean Mullan wrote: Please review this change to remove the pre-JDK 1.2 SecurityManager methods that have been deprecated since JDK 1.2 and marked for removal in JDK 9. These methods are fragile, error-prone and have been obsolete since the SecurityManager was revamped in

Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-22 Thread Alan Bateman
On 22/11/2017 15:49, Sean Mullan wrote: Hmm. Where do you see it being called inside doPrivileged? StackWalker.getInstance does a permission check when you want class refs. : Sure, the test already had everything I need so it was easier to leverage it rather than just duplicating. I had

Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-22 Thread Sean Mullan
On 11/22/17 9:59 AM, Alan Bateman wrote: http://cr.openjdk.java.net/~mullan/webrevs/8186535/webrev.00/ This mostly looks good. Does the stack walker created in AppletSecurity need to be done in a privileged block? If this is just the mouldy appletviewer tool then ignore my comment. Hmm. Wh

Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-22 Thread Alan Bateman
On 22/11/2017 14:37, Sean Mullan wrote: Please review this change to remove the pre-JDK 1.2 SecurityManager methods that have been deprecated since JDK 1.2 and marked for removal in JDK 9. These methods are fragile, error-prone and have been obsolete since the SecurityManager was revamped in JD