On Wed, 27 Apr 2022 06:55:42 GMT, Xue-Lei Andrew Fan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - typo blank linke correction
>> - revise the update
>
> ping ...
> @XueleiFan, would you please add a
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Thu, 14 Apr 2022 15:37:05 GMT, Daniel Jeliński wrote:
> IMO we should not send close_notify in the finalizer. It's the application's
> responsibility to send close_notify when it's done with the socket; we should
> not pretend that it was closed normally when it was not.
@djelinski makes
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Sat, 9 Apr 2022 14:59:13 GMT, Xue-Lei Andrew Fan wrote:
> The existing behavior is trying to close the socket and send the
> close_notify. As the socket closure has been done in the SocketImpl, I think
> BaseSSLSocketImpl could rely on to the SocketImpl cleaner. So the left for
> the
On Sat, 9 Apr 2022 11:52:01 GMT, Alan Bateman wrote:
> What is the existing behavior with the BaseSSLSocketImpl finalizer? Does it
> just close the socket or does it to the close_notify before closing the
> socket. If it does, and you want to keep that behavior, then you are probably
> into
On Fri, 8 Apr 2022 22:55:07 GMT, Bradford Wetmore wrote:
> @AlanBateman, @dfuch, @bchristi-git, any great ideas here?
As you have found, if an open Socket is unreferenced then a cleaner can close
the underlying socket (and release the file descriptor). The Cleaner is setup
by the SocketImpl
On Fri, 8 Apr 2022 06:52:57 GMT, Xue-Lei Andrew Fan wrote:
> The Socket implementation will take care of the file description/native
> memory release, I think.
I've walked through the network code and understand it now. The Socket
creation code calls into
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with two
additional commits since the last revision:
-
14 matches
Mail list logo
