On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - typo blank linke correction
> - revise the update
Marked as reviewed by wetmore (Reviewer).
src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java line 265:
> 263: }
> 264:
> 265: /**
Can you please add a quick couple lines here with the technical rationale for
removing it, so we don't forget down the road.
i.e.
There used to be a finalize() here, but decided that was not
needed. If users don't properly close the socket...
The native resources are handled by the Socket Cleaner.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8065
