Re: RFR: JDK-8210274: Source Launcher should work with a security manager

2018-09-11 Thread mandy chung
On 9/11/18 12:34 PM, Alan Bateman wrote: What are the implications for uses of javax.tools and com.sun.tools.javac.Main in code running with a security manager? Maybe that is a separate project but I would have expected to see privileged blocks in places that need permissions. The intent

Re: RFR: JDK-8210274: Source Launcher should work with a security manager

2018-09-11 Thread Jonathan Gibbons
On 09/11/2018 12:53 PM, Sean Mullan wrote: I have looked over the changes and they look reasonable, though I am not very familiar with this code. I was wondering, when running with the PermissiveTestSecurityManager did you also have to enable security debugging (ex:

Re: RFR: JDK-8210274: Source Launcher should work with a security manager

2018-09-11 Thread Jonathan Gibbons
Alan, Thanks for all the feedback. I'll add the extra test case you suggest. -- Jon On 09/11/2018 12:34 PM, Alan Bateman wrote: On 11/09/2018 19:42, Jonathan Gibbons wrote: : As regards the interaction between Source Launcher and the use of a security manager, I see 3 possibilities:

Re: RFR: JDK-8210274: Source Launcher should work with a security manager

2018-09-11 Thread Alan Bateman
On 11/09/2018 19:42, Jonathan Gibbons wrote: : As regards the interaction between Source Launcher and the use of a security manager, I see 3 possibilities: 1. Specifically support it, as provided in this webrev 2. No code change, but update JEP 330 to specify the behavior 3. Explicitly

Re: RFR: JDK-8210274: Source Launcher should work with a security manager

2018-09-11 Thread Jonathan Gibbons
On 9/11/18 12:58 AM, Alan Bateman wrote: On 10/09/2018 21:37, Jonathan Gibbons wrote: Please review a patch to have the Source Launcher be able to work when a security manager is enabled. It's not clear to me that this is an interesting use-case but in any case I think you've got two

Re: RFR: JDK-8210274: Source Launcher should work with a security manager

2018-09-11 Thread Alan Bateman
On 10/09/2018 21:37, Jonathan Gibbons wrote: Please review a patch to have the Source Launcher be able to work when a security manager is enabled. It's not clear to me that this is an interesting use-case but in any case I think you've got two scenarios to test. One is setting