Re: RFR 8050461: Tests for syntax checking of JAAS configuration file

2015-09-21 Thread Amanda Jiang
Thank you Max, Could you please sponsor this ? Thanks, Amanda On 9/21/15, 12:01 AM, Wang Weijun wrote: > Great. Everything looks fine now. > > Thanks > Max > >> 在 2015年9月21日,12:54,Amanda Jiang 写道: >> >> Hi Max, >> >> Thanks for reviewing this webrev. I have updated test cases by your comments >

Re: RFR 8050461: Tests for syntax checking of JAAS configuration file

2015-09-21 Thread Wang Weijun
Great. Everything looks fine now. Thanks Max > 在 2015年9月21日,12:54,Amanda Jiang 写道: > > Hi Max, > > Thanks for reviewing this webrev. I have updated test cases by your comments > and simplify codes, please check latest webrev below and let me know if there > are any problems: > http://cr.open

Re: RFR 8050461: Tests for syntax checking of JAAS configuration file

2015-09-20 Thread Amanda Jiang
Hi Max, Thanks for reviewing this webrev. I have updated test cases by your comments and simplify codes, please check latest webrev below and let me know if there are any problems: http://cr.openjdk.java.net/~amjiang/8050461/webrev.03/ Thanks, Amanda On 6/20/15, 7:42 AM, Weijun Wang wrote:

Re: RFR 8050461: Tests for syntax checking of JAAS configuration file

2015-06-20 Thread Weijun Wang
Hi Amanda I'd rather see 5 JAAS conf files directly included (instead of generating them with codes). Then it seems you can write a single test with 5 @run lines. Thanks Max On 6/20/2015 6:33 AM, Amanda Jiang wrote: Hello, Please help to review following changeset, which includes new tests