Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-02-13 Thread Sean Mullan
On 1/19/17 9:20 AM, Weijun Wang wrote: Another one: https://bugs.openjdk.java.net/browse/JDK-8173035 (https://bugs.openjdk.java.net/browse/JDK-8029904) Remove com.sun.security.auth.callback.DialogCallbackHandler `com.sun.security.auth.callback.DialogCallbackHandler` has been removed in JDK

Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-02-13 Thread Sean Mullan
On 1/19/17 9:20 AM, Weijun Wang wrote: On 01/19/2017 10:45 AM, Weijun Wang wrote: One more: https://bugs.openjdk.java.net/browse/JDK-8173018 (https://bugs.openjdk.java.net/browse/JDK-8076535) Deprecate the com.sun.jarsigner package The `com.sun.jarsigner` package is being deprecated. This

Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-01-22 Thread Weijun Wang
Hi Jamil Many thanks to the review. How do you think of the other two in my follow up mails? https://bugs.openjdk.java.net/browse/JDK-8173035 (https://bugs.openjdk.java.net/browse/JDK-8029904) Remove com.sun.security.auth.callback.DialogCallbackHandler `com.sun.security.auth.callback.DialogCal

Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-01-19 Thread Weijun Wang
On 01/20/2017 01:57 AM, Xuelei Fan wrote: On 1/18/2017 6:40 PM, Weijun Wang wrote: https://bugs.openjdk.java.net/browse/JDK-8173011 (https://bugs.openjdk.java.net/browse/JDK-8029995) accept yes/no for boolean krb5.conf settings krb5.conf now accepts "yes" or "no" for boolean-valued setting

Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-01-19 Thread Jamil Nimeh
Hi Max, just one nit for JDK-8044085: The release note is one sentence, but it is a bit of a run-on. It might be worth breaking it up into two sentences, the first for the description and the second containing the example. Aside from that they look good to me. --Jamil On 1/18/2017 6:40 PM,

Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-01-19 Thread Xuelei Fan
On 1/18/2017 6:40 PM, Weijun Wang wrote: https://bugs.openjdk.java.net/browse/JDK-8173011 (https://bugs.openjdk.java.net/browse/JDK-8029995) accept yes/no for boolean krb5.conf settings krb5.conf now accepts "yes" or "no" for boolean-valued settings. Looks fine to me. May be nice to state "y

Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-01-19 Thread Weijun Wang
Another one: https://bugs.openjdk.java.net/browse/JDK-8173035 (https://bugs.openjdk.java.net/browse/JDK-8029904) Remove com.sun.security.auth.callback.DialogCallbackHandler `com.sun.security.auth.callback.DialogCallbackHandler` has been removed in JDK 9. This class, in the JDK-specific exte

Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-01-18 Thread Weijun Wang
One more: https://bugs.openjdk.java.net/browse/JDK-8173018 (https://bugs.openjdk.java.net/browse/JDK-8076535) Deprecate the com.sun.jarsigner package The `com.sun.jarsigner` package is being deprecated. This includes the `ContentSigner` class, the `ContentSignerParameters` interface, and t