code review request: 7047200: keytool safe store (was Misleading error message)

2011-09-08 Thread Weijun Wang
Bug weblink: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7047200 Webrev: http://cr.openjdk.java.net/~weijun/7047200/webrev.00/ The original bug report is a false report. However, because of a simple input error, the keystore file is damaged permanently. This is definitely not a nice use

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

2011-09-08 Thread Sebastian Sickelmann
Am 07.09.2011 19:51, schrieb Sean Mullan: On 9/3/11 1:04 PM, Sebastian Sickelmann wrote: Am 02.09.2011 21:58, schrieb Sean Mullan: On 9/2/11 1:43 AM, Sebastian Sickelmann wrote: Here is the updated webrev: http://oss-patches.24.eu/openjdk8/NoSuchMechanismException/7011804_0/ Hmm, the main pro

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

2011-09-08 Thread Sebastian Sickelmann
Am 07.09.2011 19:51, schrieb Sean Mullan: On 9/3/11 1:04 PM, Sebastian Sickelmann wrote: Am 02.09.2011 21:58, schrieb Sean Mullan: On 9/2/11 1:43 AM, Sebastian Sickelmann wrote: Here is the updated webrev: http://oss-patches.24.eu/openjdk8/NoSuchMechanismException/7011804_0/ Hmm, the main pro

Re: code review request: 7047200: keytool safe store (was Misleading error message)

2011-09-08 Thread Xuelei Fan
KeyStore.store() will damage the key store/output stream because of java.lang.IllegalArgumentException: password can't be null, is it right? It seems that before the exception, there is nothing write to the output stream. I'm not sure why the key store will be damaged. What's you evaluation? Than

Re: code review request: 7047200: keytool safe store (was Misleading error message)

2011-09-08 Thread Weijun Wang
On 09/09/2011 08:52 AM, Xuelei Fan wrote: KeyStore.store() will damage the key store/output stream because of java.lang.IllegalArgumentException: password can't be null, is it right? Yes. It seems that before the exception, there is nothing write to the output stream. I'm not sure why the k

Re: code review request: 7047200: keytool safe store (was Misleading error message)

2011-09-08 Thread Xuelei Fan
Thanks for the answer. The fix looks fine to me. Thanks, Xuelei On 9/9/2011 9:38 AM, Weijun Wang wrote: > > On 09/09/2011 08:52 AM, Xuelei Fan wrote: >> KeyStore.store() will damage the key store/output stream because of >> java.lang.IllegalArgumentException: password can't be null, is it right?

hg: jdk8/tl/jdk: 7047200: keytool safe store

2011-09-08 Thread weijun . wang
Changeset: 0e6076fed003 Author:weijun Date: 2011-09-09 11:18 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e6076fed003 7047200: keytool safe store Reviewed-by: xuelei ! src/share/classes/sun/security/tools/KeyTool.java + test/sun/security/tools/keytool/trystore.sh