Your change looks fine.
I've just a comment about the units: many of the current system properties that
control timeouts are
in milliseconds. A timeout of one second may be too long for some environments.
On 27 Nov 2012, at 23:00, Jason Uh wrote:
> Could I please get a review of
> http://cr.o
Changeset: 46c627801490
Author:xuelei
Date: 2012-11-28 05:18 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c627801490
8004019: Removes unused method HandshakeHash.setCertificateVerifyAlg()
Summary: certification verification in HandshakeHash was abandoned during TLS
1.2 i
pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c627801490
Thanks for the contribution!
Xuelei
On 11/27/2012 9:29 PM, Florian Weimer wrote:
> On 11/27/2012 03:50 AM, Xuelei Fan wrote:
>
>> The fix looks fine to me. Would you like also to cleanup the comments
>> (and code for get method) r
On 11/28/2012 04:52 AM, Vincent Ryan wrote:
Your change looks fine.
I've just a comment about the units: many of the current system properties that
control timeouts are
in milliseconds. A timeout of one second may be too long for some environments.
I've looked at other implementations that su
The attached patch adds a new class
javax.net.ssl.HostnameVerifierFactory, along with an SPI class and an
implementation. This allows TLS clients to perform host name
verification without referring to the internal HostnameChecker class.
I've updated the existing TLS test case for Kerberos to
What's the motivation of the proposal?
It's more preferable to use the new X509ExtendedTrustManager and proper
endpoint identification algorithm to do hostname verification. Does the
new endpoint identification approach works for you?
Thanks,
Xuelei
On 11/28/2012 9:55 PM, Florian Weimer wrote:
Please review the following webrev which lazily initializes the
SecureRandom object used by the SunJCE provider.
In JDK 9, we want to load JCE providers with java.util.ServiceLoader as
part of the transition to modules. This can cause potential recursive
loading issues if the Sun provider for
Changeset: 735b93462eed
Author:jfranck
Date: 2012-11-28 09:21 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/735b93462eed
7154390: Add support for repeating annotations in j.l.r.AnnotatedElement
Reviewed-by: darcy
! src/share/classes/java/lang/Class.java
! src/share/classes/
On 11/28/2012 8:53 AM, Sean Mullan wrote:
Please review the following webrev which lazily initializes the
SecureRandom object used by the SunJCE provider.
In JDK 9, we want to load JCE providers with java.util.ServiceLoader
as part of the transition to modules. This can cause potential
recurs
Changeset: 1f41a5758cf7
Author:vromero
Date: 2012-11-23 15:13 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f41a5758cf7
7144981: javac should ignore ignorable characters in input
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/tools/javac/parser/JavaTokeniz
Changeset: 09bef1e118e3
Author:mchung
Date: 2012-11-28 10:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09bef1e118e3
8003851: MethodHandleNatives dependency on java.sql.DriverManager
Reviewed-by: alanb, dholmes
! src/share/classes/java/lang/invoke/MethodHandleNatives.jav
Changeset: 3b6a2fe6d75c
Author:dfuchs
Date: 2012-11-28 15:14 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b6a2fe6d75c
8003476: Cleanup warnings in com.sun.jmx.snmp code
Reviewed-by: alanb, smarks
! src/share/classes/com/sun/jmx/snmp/EnumRowStatus.java
! src/share/classes/
Sean,
Could you please provide a little more background for the motivation for
this fix? I'm not quite following yet how we get into this situation.
(Bear with me, I'm not familiar with ServiceLoader yet, so this may be a
beginner's question.)
In our current implementation, there's always b
13 matches
Mail list logo
