Why cannot overwrite a KeyEntry with a TrustCertEntry?

2013-04-11 Thread Weijun Wang
Hi All The KeyStore::setCertificateEntry has * @exception KeyStoreException if the keystore has not been initialized, * or the given alias already exists and does not identify an * entry containing a trusted certificate, * or this operation fails for some other reason. which means you cannot ov

Re: Update #5: JEP 123: SecureRandom Draft and Implementation.

2013-04-11 Thread Florian Weimer
On 04/11/2013 12:07 AM, Brad Wetmore wrote: Hi Florian, > I wonder if this change to src/share/lib/security/java.security-linux > > -securerandom.source=file:/dev/urandom > +securerandom.source=file:/dev/random > > causes the return of the blocking behavior. Welcome to my "can of worms."

Re: Why cannot overwrite a KeyEntry with a TrustCertEntry?

2013-04-11 Thread Sean Mullan
On 04/11/2013 04:36 AM, Weijun Wang wrote: Hi All The KeyStore::setCertificateEntry has * @exception KeyStoreException if the keystore has not been initialized, * or the given alias already exists and does not identify an * entry containing a trusted certificate, * or this operation fails for s

Re: Code review request: 8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in RFC3161

2013-04-11 Thread Sean Mullan
Looks good. One comment. In PKCS7.java, can you document the new tSAPolicyId parameter in the javadoc. --Sean On 04/10/2013 10:06 PM, Weijun Wang wrote: Hi Sean Please review the code changes http://cr.openjdk.java.net/~weijun/8009636/webrev.00/ Here I add a new -tsapolicycd option to j

Re: Update #5: JEP 123: SecureRandom Draft and Implementation.

2013-04-11 Thread Brad Wetmore
On 4/11/2013 3:12 AM, Florian Weimer wrote: On 04/11/2013 12:07 AM, Brad Wetmore wrote: Hi Florian, > I wonder if this change to src/share/lib/security/java.security-linux > > -securerandom.source=file:/dev/urandom > +securerandom.source=file:/dev/random > > causes the return of the blo

Re: Code review request: 8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in RFC3161

2013-04-11 Thread Weijun Wang
I added comments to two methods: + * @param tSAPolicyID the TSAPolicyID of the Timestamping Authority; + * or null if we leave the TSA server to choose one. This argument + * is only used when tsaURI is provided public static byte[] generateSignedData(byte[] sig

Re: Code review request, re-integrate JEP 115 into JDK 8

2013-04-11 Thread Brad Wetmore
On 4/8/2013 7:24 AM, Xuelei Fan wrote: Hi, Because of conflicts, we backed out the implementation of JEP 115. This fix resolves the conflicts and re-integrates JEP 115 into JDK 8. The merge is straightforward except the updates in MAC.java, CipherBox.java, EngineInputRecord.java and InputReco

Re: Why cannot overwrite a KeyEntry with a TrustCertEntry?

2013-04-11 Thread Brad Wetmore
On 4/11/2013 7:47 AM, Sean Mullan wrote: On 04/11/2013 04:36 AM, Weijun Wang wrote: Hi All The KeyStore::setCertificateEntry has * @exception KeyStoreException if the keystore has not been initialized, * or the given alias already exists and does not identify an * entry containing a trusted

Re: Code review request: 8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in RFC3161

2013-04-11 Thread Bernd Eckenfels
Should the comment describe the expected oid format for the string (Numeric only?) and mention a defining reference (RFC3161)? I havent found some sample OIDs used here, which are common? BTW: why is it linked to the URL? Bernd -- bernd.eckenfels.net Am 12.04.2013 um 02:34 schrieb Weijun Wan

hg: jdk8/tl/langtools: 2 new changesets

2013-04-11 Thread lana . steuck
Changeset: 2c9acb17f41a Author:katleman Date: 2013-04-11 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2c9acb17f41a Added tag jdk8-b85 for changeset 4a48f3173534 ! .hgtags Changeset: d13af7751456 Author:lana Date: 2013-04-11 19:15 -0700 URL: http

hg: jdk8/tl/jdk: 5 new changesets

2013-04-11 Thread lana . steuck
Changeset: e22961ea91bd Author:erikj Date: 2013-04-05 09:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e22961ea91bd 8008373: JFR JTReg tests fail with CompilationError on MacOSX; missing '._sunec.jar' Reviewed-by: tbell ! makefiles/CompileDemos.gmk ! makefiles/CompileJa

hg: jdk8/tl: 10 new changesets

2013-04-11 Thread lana . steuck
Changeset: 52d1b385a4ed Author:erikj Date: 2013-04-04 09:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/52d1b385a4ed 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure Reviewed-by: tbell, alanb ! common/autoconf/bootcycle-spec.gmk.in ! common/autoconf/s

hg: jdk8/tl/jaxws: 2 new changesets

2013-04-11 Thread lana . steuck
Changeset: 26c840af7720 Author:katleman Date: 2013-04-11 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/26c840af7720 Added tag jdk8-b85 for changeset 8c0b6bccfe47 ! .hgtags Changeset: 28886cb008bb Author:lana Date: 2013-04-11 19:15 -0700 URL: http://h

hg: jdk8/tl/hotspot: 62 new changesets

2013-04-11 Thread lana . steuck
Changeset: d26674db4d91 Author:amurillo Date: 2013-03-28 19:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d26674db4d91 8011022: new hotspot build - hs25-b26 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0c3ee6f1fa23 Author:coleenp Date: 2013-03-27