Re: webrev request: JDK-6996377

In general, the source code fix looks fine to me. A few minor comments: 1. Copyright PKIXValidator.java -- It is not have to, I normally update the copyright date to the present year when I update a file. ctortest.sh: ConstructorTest.java: - When create a new

Re: webrev request: JDK-6996377

On 05/07/2014 03:12 PM, Jamil Nimeh wrote: Please review the webrev for JDK-6996377 when you get a chance. http://cr.openjdk.java.net/~ascarpino/6996377/webrev.01/ - PKIXValidator[130]: you can use the diamond operator to make the code more concise: new HashMap<>(); - shell script test

Re: webrev request: JDK-6996377

Ah, didn't know that we were moving away from the scripts. I had thought about hard-coding certs, but I liked the on-the-fly generation approach because it kept the validity periods always within current time. But it's easy to just make really long lived certs so I'll make that change. I'll

Re: webrev request: JDK-6996377

On 05/08/2014 09:55 AM, Jamil Nimeh wrote: Ah, didn't know that we were moving away from the scripts. See https://blogs.oracle.com/jjg/entry/shelling_tests for some more rationale. I had thought about hard-coding certs, but I liked the on-the-fly generation approach because it kept the val

RFR: 8028192 : Use of PKCS11-NSS provider in FIPS mode broken

This is more or less a backport of the 8u20 code to the 7u-dev codebase. This update fixes the SunJSSE problem that in FIPS mode, SunJSSE does not work because keys cannot be extracted from crypto device. Builds and tests are good. http://cr.openjdk.java.net/~coffeys/webrev.8028192.jdk.7udev/web

[Update]: webrev request: JDK-6996377

Hello all, Updated webrev to account for Sean and Xuelei's comments is here: http://cr.openjdk.java.net/~ascarpino/6996377/webrev.02/ Thank you, --Jamil On 05/07/2014 12:12 PM, Jamil Nimeh wrote: Please review the webrev for JDK-6

Re: [Update]: webrev request: JDK-6996377

test/sun/security/validator/ConstructorTest.java Missed a "," in the copyright date line. May only need 2014 as this is a new test. - * Copyright (c) 2010, 2014 Oracle and/or its affiliates. ... + * Copyright (c) 2010, 2014, Oracle and/or its aff